On Thursday February 12 2009, Robert Fischer wrote: > > Getting back to the original topic, code reviews are good, but I've > never seen the "mandatory pre-check-in review" work for long. I've > heard of places where it's worked well, but these places seem > downright mythical to me because I've never seen it last for > myself. Sooner or later, people get lazy about doing them, and > code just gets pushed in because it "has to go out".
We have it going at my workplace and have been for a few years now. We used to to mostly what we call over the shoulder reviews but we started to use crucible and that is now much more common. We actually often have multiple reviewers per commit and it has done wonders to our code base as far as I can tell. I strongly recommend using a tool like crucible allowing offline code reviews. I often do a couple of reviews in batch and it takes me an hour or so. manfred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "The Java Posse" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/javaposse?hl=en -~----------~----~----~----~------~----~------~--~---
