Btw, you caught me off guard this morning Rickard, and with my coffee I go
"hmmmmm wtf"
Ok first of all in the createEntity method that I factored there was no
distinction CMP/BMP that i saw, it is normal... the reason is simple you
still havent' done BMP :) but I take you are saying do as I say not as I
do:)
second even if there was one. I repeat that not exposing the "boolean
isCMP" from the metadata is a bit of a design poopoo in the first place
(review jboss 1.0 for that, it does it correctly and lets the container
branch). And basing the decision of the container calls to be put in the
JAWS layer based on that poopoo is even more of a silly decision. This
whole branch of the decision taking is based on a flawed root (the metadata
is not correctly exposed in the first place) let's cut that branch and not
start arguing on the logic in the leaves.
On average your code is truly great rickard (even bordering to genius
sometimes) and sometimes you go "hmmm he was tired that evening, too much
candy". I want to clean in peace and stop wasting my time. You won't
regret it.
At ease!
marc
> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]]On Behalf Of marc fleury
> Sent: Saturday, July 08, 2000 11:27 AM
> To: jBoss Developer
> Subject: RE: [jBoss-Dev] setEJBObject
>
>
>
> > > Please review the changes it is pretty trivial and I will put
> > it in the find
> > > methods as well :)
> >
> > -1. Doing these calls in EntityContainer won't work. Motivation:
> > * There is a difference in semantics of these calls between BMP and CMP.
> > The only part that knows if we're doing BMP or CMP is the persistence
> > manager. Hence the persistence manager must make these calls. The
>
> wrong.
>
> exposing CMP or BMP with metadata is trivial really.
> And then we can do the right thing re: implementing EJB calls in the right
> place.
>
> Don't make a big architectural decision such as "all ejb calls will be
> called by the persistence engine" based on the fact you don't put the
> relevant information in the right place.
>
>
>
> > persistence manager also makes all the other calls so this is nothing
> > new.
> > * EntityContainer is glue only. It should not do any actual work. All it
> > does is delegate to other parts to do the actual work.
>
> wow, JAWSPersitenceManager.java is "container" but EntityContainer.java is
> "glue"?????
>
> wow, you can't be serious.
>
> BTW, before talking about the create stuff we are debugging (still doesn't
> work ;-) maybe fixing the find bug would be more productive.
>
> marc
>
> > I saw that you have already made the change, so please change it back.
> >
> > /Rickard
> >
> > --
> > Rickard �berg
> >
> > @home: +46 13 177937
> > Email: [EMAIL PROTECTED]
> > http://www.telkel.com
> > http://www.jboss.org
> > http://www.dreambean.com
> >
> >
>
>
>
