Ok, it looks like the OpenJMS is only referenced directly in these
files:
o src/main/org/jboss/jms/asf/OpenJMSServerSessionPoolFactory.java:
import org.exolab.jms.client.OpenJMSServerSessionPool;
import org.exolab.jms.client.JmsServerSessionPool;
org.exolab.core.logger.LoggerIfc logger =
org.exolab.core.logger.LoggerFactory.create(null, null);
org.exolab.core.logger.LogEventType event =
org.exolab.core.logger.LogEventType.getLogEventType("debug");
o src/main/org/jboss/jms/jndi/OpenJMSProvider.java:
public static final String INITIAL_CONTEXT_FACTORY =
"org.exolab.jms.jndi.rmi.RmiJndiInitialContextFactory";
private static final String HOST_PROP_NAME="org.exolab.jms.jndi.Host";
private static final String
PORT_PROP_NAME="org.exolab.jms.jndi.PortNumber";
o src/main/org/jboss/ejb/plugins/jms/JMSContainerInvoker.java:
public String getType() { return "org.exolab.castor.jdo.DataObjects";
//import org.exolab.jms.jndi.JndiConstants;
import org.exolab.jms.client.JmsServerSessionPool;
---
The last of which imports an OpenJMS class, but does not make use of it.
Except for JMSContainerInvoker, these classes are not referenced anywhere
else in the system either.
I can understand wanting to clean up unused sources and thirdparty
libraries, but I am wondering what if someone wanted to make use of
OpenJMS? These classes seem like a good candidate for an external plugin
module, but I am not really sure what the precedent is for that.
It would be nice to have a 'plugin' module, which could some child
modules, one for 'openjms'. Perhaps that is what the 'contrib' module is
for?
With the above OpenJMS specific classes removed and these library files:
o src/lib/openjms-client-patched-0.5.1.jar
o src/lib/openjms-patched-0.5.1.jar
o src/lib/openjms-pool.jar
o src/lib/openjms-rmi-patched-0.5.1.jar
I was able to build and execute the default configuration with no errors.
So any ideas on what I should do? Should I proceed and commit these
changes, thus removing OpenJMS support from JBoss, or should I attempt to
preserve these classes in an external project for those who still use
OpenJMS?
I have not investigated the log4j bits yet, are there classes as well as
library files for that too?
--jason
On Sun, 15 Apr 2001, Juha Lindfors wrote:
>
> Wanna take a look at the OpenJMS stuff too? :)
>
> It takes a meg in our package, and seems unnecessary as we use JBossMQ for
> MDB.
> The old log4j might be a good candidate for removal as well.
>
> -- Juha
>
> At 14:17 14.4.2001 -0700, you wrote:
> >DependencyManager and jboss.dependencies have been removed. I also
> >updated Main to remove the import of DependencyManager. I verified that
> >the system builds correctly and runs with no other modifications too.
> >
> >--jason
> >
> >On Sat, 14 Apr 2001, marc fleury wrote:
> >
> >> |>From my investigation I would say that it is not being used anywhere
> >> |inside of the jboss project. If this is true, it might be a good
> >> |idea to at
> >> |least remove the jboss.dependencies from the conf/default directory so
> that
> >> |it does not confuse anyone.
> >>
> >> correct,
> >>
> >> |I think that the DependencyManager is a good one, so I would not
> >> |be so quick
> >> |to suggest that it be removed.
> >>
> >> it was not a good one, remove it, we need to simplify simplify simplify
> >>
> >> marc
> >> |http://lists.sourceforge.net/lists/listinfo/jboss-development
> >>
> >>
> >> _______________________________________________
> >> Jboss-development mailing list
> >> [EMAIL PROTECTED]
> >> http://lists.sourceforge.net/lists/listinfo/jboss-development
> >>
> >
> >
> >_______________________________________________
> >Jboss-development mailing list
> >[EMAIL PROTECTED]
> >http://lists.sourceforge.net/lists/listinfo/jboss-development
> >
>
> _______________________________________________
> Jboss-development mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/jboss-development
>
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development
