> Does anyone know why all of the fields in org.jboss.ejb.Application are
> declared with package (default) access? Most of the classes that I have
> looked at in org.jboss.ejb have fields with package access. If there is not
> a good reason, I suggest that we make these private as this helps to
> prevent spaghetti code.
I do not think there is a strong reason for it. Though I would not suggest
private for classes which we might expect folks to want to extend from
(unless there are getter/setter methods for the appropriate fields).
Private access is great where private access should be applied, though it
looks like many folks like to just make everything private (like most of the
stuff from the ant project) which makes it very, very, very hard to
customize and such.
I think it would be good to use private or protected where package private
is not required. I would just be careful not to make everything private,
where it might not be appropriate.
--jason
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development