so uh... I actually went and read the DeploymentScanner and MainDeployer stuff, it is actually good.
There I said it. It suffers from some "jasonisms" meaning the abstract hello world, but all in all it is actually a pretty piece of work. Yes the hardcode of MainDeployer is bad but then he DID keep it simple for once and it is up to the next person using it for some other purpose to hook the DS to the Farm deployer and that is Andreas' role. The kid did his task and did it well, give him a break. As far as the MBeanProxy is concerned, yes the fact that it is detyped is dangerous, that is what JMX IS ABOUT -- DETYPING & DETACHING-- so really let's not complain. In fact I want to extend the MBeanProxy to live in clients, which is trivial to do with the new client interceptor approach but I will leave that part for BillB to do :) So ok, I am leaving tomorrow, I want to try and *compile* the client interceptors to break the build again before I leave and then it is JBossONE. JBoss One is going to be one hell of a show, we got people writing EVERY day saying "I am flying JUST FOR YOU GUYS, can I reserve a seat", it is going to be great, wait and see. But really what I want to say is that I feel we are reaching a new stage in our development. So I will write more on the state of the union when I have a moment, but for now keep it cool, this whole thing is going to go to a whole new level, let's reach that level in peace as there will be a lot more war a lot more stress and a lot more fun. We are all in this together, you are NOT alone... I repeat you are not alone marcf |-----Original Message----- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of Jason |Dillon |Sent: Wednesday, March 06, 2002 4:27 PM |To: David Jencks |Cc: [EMAIL PROTECTED] |Subject: Re: [JBoss-dev] MBeanProxy and AbstractDeploymentScanner | | |What does FarmDeployer actually do? | |--jason | | |David Jencks wrote: | |>On 2002.03.06 18:36:25 -0500 Jason Dillon wrote: |> |>>MainDeployer was orginally slated to be an instance of DeployerMBean, |>>but someone refactored that interface such that it would not apply here |>>anymore... |>> |> |>Maybe a really long time ago, but neither my proposed revision or marcs |>rewrite would work with MainDeployer being the same kind of thing as a |>subdeployer. Maybe we should rename DeployerMBean to SubDeployer to make |>this clearer. |> |>I think the FarmDeployer has to be the same kind of thing as MainDeployer, |>not a DeployerMBean/SubDeployer. |> |>david jencks |> |>>--jason |>> |>> |>>David Jencks wrote: |>> |>>>After enthusiastically using mbean proxies for a while now I'm going to |>>>turn around and agree with Andreas that they are kind of a bad idea. |>>> |>>For |>> |>>>instance, I think they led Jason to not put the MainDeployer as an |>>>attribute of the scanner because Main Deployer and the farm deployer |>>> |>>don't |>> |>>>extend a common interface. All they need is to have some of the same |>>>methods. |>>> |>>>btw notice I am saying farm deployer should be like MainDeployer, and |>>> |>>not |>> |>>>extend DeployerMBean. |>>> |>>>david jencks |>>> |>>>On 2002.03.06 01:47:45 -0500 Jason Dillon wrote: |>>> |>>>>>So you want to have an interface floating around even it is only used |>>>>> |>>>>for |>>>> |>>>>>this MBeanProxy ? |>>>>> |>>>>In short yes. I would rather have calls like |>>>> |>>>>serviceController.create(objectName); |>>>> |>>>>over |>>>> |>>>>server.invoke(controllerName, |>>>> new Object[] { objectName }, |>>>> new String[] { ObjectName.class.getName() }); |>>>> |>>>>It is easier to read/maintain, provides some level of type safety... |>>>>simplifies the client code. |>>>> |>>>>--jason |>>>> |>>>> |>>>>_______________________________________________ |>>>>Jboss-development mailing list |>>>>[EMAIL PROTECTED] |>>>>https://lists.sourceforge.net/lists/listinfo/jboss-development |>>>> |>>>> |>>>_______________________________________________ |>>>Jboss-development mailing list |>>>[EMAIL PROTECTED] |>>>https://lists.sourceforge.net/lists/listinfo/jboss-development |>>> |>> |>> |>>_______________________________________________ |>>Jboss-development mailing list |>>[EMAIL PROTECTED] |>>https://lists.sourceforge.net/lists/listinfo/jboss-development |>> |>> |> |>_______________________________________________ |>Jboss-development mailing list |>[EMAIL PROTECTED] |>https://lists.sourceforge.net/lists/listinfo/jboss-development |> | | | |_______________________________________________ |Jboss-development mailing list |[EMAIL PROTECTED] |https://lists.sourceforge.net/lists/listinfo/jboss-development _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
