>
>
>There I said it.  It suffers from some "jasonisms" meaning the abstract
>hello world, but all in all it is actually a pretty piece of work.
>

I can see how that might appear now that DirectoryDeploymentScanner was 
removed... though there was a reason for it when I wrote it.  I don't 
just seperate abstracts for shits and giggles.

>Yes the hardcode of MainDeployer is bad but then he DID keep it simple for
>once and it is up to the next person using it for some other purpose to hook
>the DS to the Farm deployer and that is Andreas' role.  
>

As I said before, I had planned to use a settable here, but there was no 
interface todo it.  I certainly could have used ObjectName + 
MBeanServer.invoke(), but it was easier to leave it as is until a proper 
interface could be put here.

Plus, as the name suggests MainDeployer, it is the primary interface 
which clients will use to deploy stuff... so the hard code isn't so 
bad... unless we start adding secondary interfaces for specialled behavior.

I felt the need to clarify these two bits... rather justify my 
reasons... but I am gonna drop it now.

Thanks for actually taking a look.

--jason



_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to