Make it simple. Duplicate the code. It's not that big of a deal. These classes don't have much logic in them anyways.
I think you're missing something. There are commented out imports and commented out code. Well...you'll find out when you do a 1.4 build anyways. > -----Original Message----- > From: Jason Dillon [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, March 20, 2002 11:12 PM > To: Bill Burke > Cc: Jboss-Dev > Subject: Re: [JBoss-dev] expanding buildmagic for JDK 1.4 > > > Looks like the easiest thing todo short-term is is to include > java.sql.Savepoint and java.sql.ParameterMetaData when not compiling > with JDK 1.4. I don't really like it, but the alternative is to > duplicate code, or write wrappers around the bits that use these to use > version specific targets... which I like even less. > > So, JDK 1.3 builds will include these two classes in jboss-jca.jar and > will be omitted in JDK 1.4, leaving the resource\adapter\jdbc\local > classes the same for either. > > Sound ok... or am I missing something? > > --jason > > > Bill Burke wrote: > > >Thanks dude. That would be great. Look in > >...\jboss-all\connector\src\main\org\jboss\resource\adapter\jdbc\local > > > >Search for 1.4 in the files there. You'll see that some imports > and code is > >commented out and is labeled as 1.4 code. It should be self > explanatory by > >looking at the file. > > > >Thanks, > > > >Bill > > > >>-----Original Message----- > >>From: [EMAIL PROTECTED] > >>[mailto:[EMAIL PROTECTED]]On Behalf Of Jason > >>Dillon > >>Sent: Wednesday, March 20, 2002 10:17 PM > >>To: Bill Burke > >>Cc: Jboss-Dev > >>Subject: Re: [JBoss-dev] expanding buildmagic for JDK 1.4 > >> > >> > >>I can spare some time to work on this. Do you know which classes need > >>special attention? > >> > >>--jason > >> > >> > >>Bill Burke wrote: > >> > >>>Just compiled and ran stuff with JDK 1.4. I had to uncomment > >>> > >>out the JDBC > >> > >>>3.0 stuff in the connector code though. It would be nice if we could > >>>conditionally compile this stuff in. > >>> > >>>Jason, build meisters...In ant, can you determine the version of the > >>>compiler you're compiling with and do a conditional compilation > >>> > >>on different > >> > >>>source trees? > >>> > >>>Regards, > >>> > >>>Bill > >>> > >>> > >>>_______________________________________________ > >>>Jboss-development mailing list > >>>[EMAIL PROTECTED] > >>>https://lists.sourceforge.net/lists/listinfo/jboss-development > >>> > >> > >> > >>_______________________________________________ > >>Jboss-development mailing list > >>[EMAIL PROTECTED] > >>https://lists.sourceforge.net/lists/listinfo/jboss-development > >> > > > > > >_______________________________________________ > >Jboss-development mailing list > >[EMAIL PROTECTED] > >https://lists.sourceforge.net/lists/listinfo/jboss-development > > > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
