I thought we were arguing over two things 1) That both joinpoint instances and invocation instances need metadata lookups. I think we both agree that joinpoint instances need metadata lookup. Do we agree that invocation intances need a separate metadata lookup?
2) I thought I had agreed that there doesn't need to be a separate API for getAnnotation and getMetaData. Maybe I agreed in my head, but forgot to post or maybe you didn't read one of my posts. 3) I thought we were disagreeing that the aspect factory needs a way to query for metadata from the bean class to determine additional dependencies. That I thought the aspect factory needed a way to query for metadata, and that you didn't. Some thoughts: * Class LEVEL: JBoss AOP Aspects are woven into a class at class static initialization time when using bytecode weaving (not a container + proxy). Will we be doing dependency management for this level of AOP? If so I'm worried about two things: complexity and performance. For complexity I'm worried that if we are doing dependency management at class static initialization we may run into difficult to debug deadlocks and circular class dependencies. For performance, I don't want to proxy aspect instances to solve complexity problems as the overall performance of JBoss AOP is quite sensitive as we're now down to the level of counting bytecode instructions. * Bean Level: Do aspect dependencies at this level only worry about beans managed by aspectized containers? * Finally, I think we need to discuss this on a separate thread, but I think the Joinpoints cannot use strings for parameters types, return types, and fields types. The AOP pointcut expression matcher will need to query these types to see if they have a corresponding annotation. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=3861638#3861638 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=3861638 ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
