Maciej Swiderski [http://community.jboss.org/people/swiderski.maciej] replied 
to the discussion

"JBPM-2537"

To view the discussion, visit: http://community.jboss.org/message/540999#540999

--------------------------------------------------------------
Hi guys,

finally I found some time to look into this issue.

First of all I don't see anything wrong with adding methods (such as timeout or 
cancel) to activity behavior - to me they are regular life cycle methods of the 
activity. Especially that one of the core funtinalities is timers.
Next, ExternalActivityBehaviour is not modified. That's why new interface was 
created (TimeoutActivityBehaviour) and this interface is only implemented by 
TaskActivity.

I have tried the patch from jira (20100227-JBPM-2753) but unfortunately it is 
incomplete. There are few things missing - mainly those that Ronald posted 
inline. I made some modification to make it to work. So, currently both issues 
seems to have a solution:
- JBPM-2753 - uses timeout to close task
- JBPM-2807 - uses cancel to close task

Main change compared to Ronlad's changes is to make Timer to make use of new 
signaling - marking it as timeout aware. It uses new signal constructor 
introduced by Ronald.

I will put some comments and the patch into jira later today.

Let me know your comments.

Cheers,
Maciej

--------------------------------------------------------------

Reply to this message by going to Community
[http://community.jboss.org/message/540999#540999]

Start a new discussion in jBPM Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2035]

_______________________________________________
jboss-user mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/jboss-user

Reply via email to