----- Original Message ----- > Hi, > > Ẃith Oracle Java SE Critical Patch Update live, I'm now requesting > approval to push the changes into jdk6-open. > > webrev: http://cr.openjdk.java.net/~ewendeli/6ssr/ > > Please review. > > Thanks, > Edvard >
I haven't reviewed the whole thing but the following files are missing license headers: jdk/test/javax/swing/Security/7186948/bug7186948.java jdk/test/javax/swing/Security/7200491/applet.policy jdk/test/javax/swing/Security/7200491/bug7200491.java jdk/test/javax/swing/Security/7200491/bug7200491_2.html jdk/test/javax/swing/Security/7200491/bug7200491_2.java jdk/test/javax/swing/Security/7200491/bug7200491_3.html jdk/test/javax/swing/Security/7200491/bug7200491_3.java Should these have been included? I don't see how the code itself can be reviewed effectively when we don't know what issues are supposed to be fixed. I didn't check all of them but most of the referenced bug IDs aren't visible. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
