On 02/07/2013 02:08 PM, Edvard Wendelin wrote: > I'll look into the headers and generate a new webrev.
Hi Edvard, This has gone very quiet. What's up? Thanks, Andrew. > On 02/07/2013 02:14 PM, Andrew Hughes wrote: >> I haven't reviewed the whole thing but the following files are missing >> license headers: >> >> jdk/test/javax/swing/Security/7186948/bug7186948.java >> jdk/test/javax/swing/Security/7200491/applet.policy >> jdk/test/javax/swing/Security/7200491/bug7200491.java >> jdk/test/javax/swing/Security/7200491/bug7200491_2.html >> jdk/test/javax/swing/Security/7200491/bug7200491_2.java >> jdk/test/javax/swing/Security/7200491/bug7200491_3.html >> jdk/test/javax/swing/Security/7200491/bug7200491_3.java >> >> Should these have been included? >> >> I don't see how the code itself can be reviewed effectively when we don't >> know what issues >> are supposed to be fixed. I didn't check all of them but most of the >> referenced bug IDs >> aren't visible. > >