Hi, * Nikolay Gorshkov <niko...@azulsystems.com> [2014-07-14 16:17]: > I'd like to propose the following changeset comment format for situations > when the creator and the backporter of the fix are two different persons: > > 1234567: NPE thrown on FileInputStream("") > Summary: Rewrite precondition-checking code in io.c > Reviewed-by: mr > Contributed-by: Ben Bitdiddle <b...@bits.org> > Authored-by: Joe Bloggs <joe.blo...@example.com> > > "Authored-by" field points to the original author of the fix. It may be > just an OpenJDK username or a combination of a full name and an email > address like it appears currently in "Contributed-by" field. Please, > let me know if you are OK with this format for further backports.
Personally, I like this proposal. It also seems general enough to be useful in other OpenJDK projects as well as OpenJDK 6. I think it would be better to bring this up for wider discussion. Because this will require changes to jcheck [1] too. jcheck, if you are not familiar with it, is what enforces commit messages. Thanks, Omair [1] http://hg.openjdk.java.net/code-tools/jcheck/ -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681