----- Original Message ----- > Hello Omair, > > thank you for review. I agree with your proposal to backport 8010213. Please > note that the bug record for 8010213 isn't accessible outside Oracle, I > suppose due to security restrictions. I won't be able to create backport > record for 8010213 and update main record. > > Could you please point me at backport process in OpenJDK6? Are there any > docs? >
I've pushed it: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/1492971e2155 You've already done most of the work by identifying, testing and submitting the backport. The process for applying it to the tree is simply: $ hg log -R ../../jdk7/jdk -k 8010213 changeset: 6293:a7299af2af32 user: khazra date: Wed Mar 20 13:39:56 2013 -0700 summary: 8010213: Some api/javax_net/SocketFactory tests fail in 7u25 nightly build $ hg export -R ../../jdk7/jdk -r 6293|hg import - $ hg out comparing with ssh://hg.openjdk.java.net/jdk6/jdk6/jdk searching for changes changeset: 920:1492971e2155 tag: tip user: khazra date: Wed Mar 20 13:39:56 2013 -0700 summary: 8010213: Some api/javax_net/SocketFactory tests fail in 7u25 nightly build $ hg push A build should be done following the export/import stage, along with testing that the fix has worked. In this case, you'd already done this and there would be nothing for me to test on a non-Windows platform anyway. > Regards, > - Vlad > > -----Original Message----- > From: Omair Majid [mailto:oma...@redhat.com] > Sent: Friday, July 18, 2014 19:34 > To: Vladislav Karnaukhov > Cc: jdk6-dev@openjdk.java.net > Subject: Re: Review request for OPENJDK6-38: java.net.Socket > getTcpNoDelay/setTcpNoDelay work incorrectly on Windows > > Hi, > > * Vladislav Karnaukhov <vladis...@azulsystems.com> [2014-07-18 04:09]: > > please review the fix for OPENJDK6-38: java.net.Socket > > getTcpNoDelay/setTcpNoDelay work incorrectly on Windows > > > > webrev: http://cr.openjdk.java.net/~vkarnauk/OPENJDK6-38/webrev.00/ > > > > I fixed the bug independently from the fix 8010213, though the fixes > > are identical. I don't mind at all if my fix will be marked as a > > backport of 8010213 for consistency. > > I am not familiar with windows networking, but since this is identical to the > JDK 7 fix I have no objections. > > I would strongly prefer however, that 8010213 was backported directly > (through hg export/hg import), rather than through an OpenJDK6-specific bug. > This keeps track of the bug id (which makes tracking of backported fixes > easier in the future) and also keeps the code as close as possible (which > makes applying future fixes easier). > > Thanks, > Omair > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
