On 9/15/11 10:49 AM, Mala Bankal wrote: > HI Dalibor, > > a) I can't see the bug on bugs.sun.com - please describe what this > change is supposed to fix. > > 6.0 and 5.0 introduce extract escape character. > for e.g if CN = "Qpass Inc" > older jdk 5.0 and 6.0 keytool prints CN = "Qpass Inc" > later ones print CN = "\"Qpass Inc\"" > Behaviour introduced due to Bug # 6927152. > Fix is to check if string is already quoted, don't re-quote
Great, thanks. > b) Is the changeset athttp://hg.openjdk.java.net/jdk8/tl/jdk/rev/52bc200b14e5 > the same patch as > inhttp://cr.openjdk.java.net/~mbankal/7049963/webrev.00/? > > Yes Unfortunately, not quite - there is a change in the copyright block in your webrev, that's not present in the changeset that was pushed into jdk8. So I have to ask Sean to take another look at it per our code review process. See the Project home page for details. cheers, dalibor topic -- Oracle <http://www.oracle.com> Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment