On 9/15/11 11:07 AM, Chris Hegarty wrote: > On 09/15/11 10:00 AM, Dalibor Topic wrote: >> .... >> >> Unfortunately, not quite - there is a change in the copyright block in your >> webrev, >> that's not present in the changeset that was pushed into jdk8. So I have to >> ask Sean > > From time to time the issue of who should update the year ranges in the > copyright header comes up. I think this is a case against it being updated as > part of a bug fix.
I think updating it in a bug fix would be perfectly fine if this was a 7u specific fix. Since it's not, i.e. the fix is coming from 8, a difference there makes me wonder why there is a difference, and since I didn't see the difference explained or pointed out in the request for approval, I have to ask questions to learn why it's there. To be clear, I would be perfectly fine with this fix going in without any further review if it's the same fix as in 8, as per our process - i.e. without the update to the year range. cheers, dalibor topic -- Oracle <http://www.oracle.com> Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment