Thanks Seán!
Then I'll ask for an approval to backport 8007454, which is applied cleanly.
And once it is pushed, I'll initiate a review for 7147084 with adjustments.
Sincerely,
Ivan
On 24.09.2013 12:59, Seán Coffey wrote:
Approved for jdk7u-dev but you'll need a review first due to the
adjustments needed in the backport.
Hopefully, you'll be resolving these issues with 2 different
changesets. It's been the trend in the past and helps keep changesets
more aligned to those in JDK 8.
regards,
Sean.
On 24/09/2013 09:08, Ivan Gerasimov wrote:
Sending to the correct ML
--------------
Hello!
We have a request to backport fix for 7147084.
First, it depends on the fix for 8007454, so the webrev includes it too.
Second, the fix had to be adjusted a bit.
- I had to manually replaced Java_java_lang_ProcessImpl_create()
function body with the new version, as 'hg patch' could not handle
automatically.
- I had to replace wide-char strings to regular char*, in all the
calls to win32Error() function.
Combined webrev:
http://cr.openjdk.java.net/~igerasim/7147084/0/webrev/
BUGS:
http://bugs.sun.com/view_bug.do?bug_id=7147084
http://bugs.sun.com/view_bug.do?bug_id=8007454
JDK8 Changesets:
7147084: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c4f1081a0fa
8007454: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a2b308cc82d
Reviews for jdk8 fix:
7147084:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/019604.html
8007454:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014602.html
I had set up a JPRT job, which completed successfully.
All the .*jdk_lang.* test passed.
Sincerely yours,
Ivan Gerasimov
