I need a second 7u reviewer for this 7u60 critical request fix (very simple fix).

Could someone review it please ?

Thanks,
Olivier.

Christian Thalinger said  on date 1/23/2014 10:09 PM:
Looks good.

On Jan 21, 2014, at 12:41 AM, Olivier Lagneau <olivier.lagn...@oracle.com <mailto:olivier.lagn...@oracle.com>> wrote:

Please find the new webrev with copyright date fixed (changed to 2014).

Webrev: http://cr.openjdk.java.net/~olagneau/8019389/webrev.01/ <http://cr.openjdk.java.net/%7Eolagneau/8019389/webrev.01/>

Olivier.

Olivier Lagneau said  on date 1/20/2014 5:50 PM:
Oops, right !

Will fix that.

Olivier.

shanliang said  on date 1/20/2014 4:13 PM:
Olivier,

Now it is 2014 :)


Olivier Lagneau wrote:
Please review the following simple fix.

Issue: https://bugs.openjdk.java.net/browse/JDK-8019389
Webrev: http://cr.openjdk.java.net/~olagneau/8019389/webrev.00/ <http://cr.openjdk.java.net/%7Eolagneau/8019389/webrev.00/>

The issue is due to the fact that _invokeHandle bytecode is generated by hotspot, but is not declared in agent code. Just declaring the new bytecode solves the assertion failure.

However the tests reported in 8019389 (bootstrapOtherStratumInStackTrace, targetOtherStratumInStackTrace) suffer the problem from JDK-7016268 <https://bugs.openjdk.java.net/browse/JDK-7016268> : Can't get strata information through SA-JDI Thus, the "stratum mismatch" related to JDK-7016268 will still be present after fix.
This second problem has to be fixed through JDK-7016268.

Thanks,
Olivier.





Reply via email to