On 2/4/14 3:10 AM, Olivier Lagneau wrote:
Thanks Serguei !

This is a 7u only fix. This code is already present in 8 and 9.
Ok, thanks.
Just in case, I've attached one of the latest e-mail notifications from Alejandro.
Ask questions if there is any confusion.

Thanks,
Serguei


Olivier.

serguei.spit...@oracle.com said  on date 2/4/2014 12:03 PM:
Hi Oliver,

The fix looks good.
Was this already fixed in the JDK 9 and 8?

Thanks,
Serguei

On 2/4/14 2:15 AM, Olivier Lagneau wrote:
I need a second 7u reviewer for this 7u60 critical request fix (very simple fix).

Could someone review it please ?

Thanks,
Olivier.

Christian Thalinger said  on date 1/23/2014 10:09 PM:
Looks good.

On Jan 21, 2014, at 12:41 AM, Olivier Lagneau <olivier.lagn...@oracle.com <mailto:olivier.lagn...@oracle.com>> wrote:

Please find the new webrev with copyright date fixed (changed to 2014).

Webrev: http://cr.openjdk.java.net/~olagneau/8019389/webrev.01/ <http://cr.openjdk.java.net/%7Eolagneau/8019389/webrev.01/>

Olivier.

Olivier Lagneau said  on date 1/20/2014 5:50 PM:
Oops, right !

Will fix that.

Olivier.

shanliang said  on date 1/20/2014 4:13 PM:
Olivier,

Now it is 2014 :)


Olivier Lagneau wrote:
Please review the following simple fix.

Issue: https://bugs.openjdk.java.net/browse/JDK-8019389
Webrev: http://cr.openjdk.java.net/~olagneau/8019389/webrev.00/ <http://cr.openjdk.java.net/%7Eolagneau/8019389/webrev.00/>

The issue is due to the fact that _invokeHandle bytecode is generated by hotspot, but is not declared in agent code. Just declaring the new bytecode solves the assertion failure.

However the tests reported in 8019389 (bootstrapOtherStratumInStackTrace, targetOtherStratumInStackTrace) suffer the problem from JDK-7016268 <https://bugs.openjdk.java.net/browse/JDK-7016268> : Can't get strata information through SA-JDI Thus, the "stratum mismatch" related to JDK-7016268 will still be present after fix.
This second problem has to be fixed through JDK-7016268.

Thanks,
Olivier.








--- Begin Message ---

On 1/31/2014 4:51 PM, Alejandro E Murillo wrote:
Starting immediately, any hotspot change destined for 7u60 should go to:

hg.openjdk.java.net/hsx/jdk7u60/hotspot

These repos may not be available until the end of  the day today

This means that hg.openjdk.java.net/hsx/jdk7u/ is now associated to 7u80,
so any hotspot change destined to 7u80 should be pushed to that repo.

As usual do not hesitate to ask if you have any question
thanks

To follow the same model followed for non hotspot changes(see [1]),
all hotspot changes intended for 7u (7u60 and 7u80 for the time being),
 should be pushed, as usual to hsx/jdk7u/hotspot [2].

I will then snapshot and PIT as usual and push to the jdk7u master and jdk7u-dev,
and from there, the 7u60 changes will be brought to the 7u60 stabilization
repos [3] and [4]  by the repo maintainers.

so do not push anything to hsx/jdk7u60/hotspot,
please push to hsx/jdk7u/hotspot as usual.

apologies this created any confusion
thanks

--
Alejandro


--- End Message ---

Reply via email to