Looks good.
/Jesper
Stefan Johansson skrev 8/10/14 10:55:
Adding hotspot-gc-dev.
On 2014-10-07 15:31, Stefan Johansson wrote:
Hi,
Please review this backport to 7u-dev for:
https://bugs.openjdk.java.net/browse/JDK-8026303
Full webrev:
http://cr.openjdk.java.net/~sjohanss/8026303/webrev.00/
Webrev for changes to original fix:
http://cr.openjdk.java.net/~sjohanss/8026303/webrev.changeset/
Summary:
Backporting the fix for 8026303 will solve JDK-8055730, but the changeset
doesn't apply clean to 7u-dev because of some refactoring and name changes.
In 8 & 9 the method "dict_census_update" was misspelled (dict_census_udpate)
and we didn't have an AdaptiveFreeList<FreeChunk> but instead used
FreeList<FreeChunk>. Changing these name conflicts to the original changeset
makes it apply clean and I have verified that the bug we want to fix goes
away after applying it.
Some more information is available below in the original Request for approval
mail I sent out.
Thank,
Stefan
On 2014-09-30 14:51, Stefan Johansson wrote:
Hi,
Please approve the backport of the fix for JDK-8026303 to jdk7u-dev. This
fix resolves the issue reported in JDK-8055730:
https://bugs.openjdk.java.net/browse/JDK-8055730
The changeset applies without any conflicts after the changeset has been
modified to match JDK-7 source. Two main changes was done to the changeset,
see this webrev for details:
http://cr.openjdk.java.net/~sjohanss/8026303/webrev.changeset/
Full webrev:
http://cr.openjdk.java.net/~sjohanss/8026303/webrev.00/
Original bug:
https://bugs.openjdk.java.net/browse/JDK-8026303
Original webrev:
http://cr.openjdk.java.net/~jmasa/8026303/webrev.00/
Original changeset:
http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/0ade41b2dbeb
Review:
http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2013-November/008976.html
Thanks,
Stefan
