Yup, approved. Can you forward a link to the 7 codereview thread? Thanks,

    -Rob

On 08/10/14 15:06, Stefan Johansson wrote:
Hi again Rob,

Now the fix for 8026303 is backported to 8u and I have gotten two reviews of the code proposed to be backported into 7u. Is it ok to push these changes to jdk7u-dev then?

Thanks,
Stefan


On 2014-10-06 16:06, Rob McKenna wrote:
Ah, see what you mean. I was looking at the wrong bug there. Thanks Stefan,

    -Rob

On 06/10/14 14:53, Stefan Johansson wrote:
Thanks Rob,

JDK-8026303 is fixed in 9 but yet not backported to 8u. The patch applies clean on 8u so I will do that backport and then request a normal review for getting it into 7u

Cheers,
Stefan

On 2014-10-06 15:35, Rob McKenna wrote:
Hi Stefan,

This needs to be fixed in 9 & 8u first. Also given that there are changes to the original fix it will need a codereview for 7.

    -Rob

On 06/10/14 14:01, Stefan Johansson wrote:
Ping,

Who is responsible for approving backports needed for linux-sparc? Do we need to anything special to get this approved?

Thanks,
Stefan

On 2014-09-30 14:51, Stefan Johansson wrote:
Hi,

Please approve the backport of the fix for JDK-8026303 to jdk7u-dev. This fix resolves the issue reported in JDK-8055730:
https://bugs.openjdk.java.net/browse/JDK-8055730

The changeset applies without any conflicts after the changeset has been modified to match JDK-7 source. Two main changes was done to the changeset, see this webrev for details:
http://cr.openjdk.java.net/~sjohanss/8026303/webrev.changeset/

Full webrev:
http://cr.openjdk.java.net/~sjohanss/8026303/webrev.00/

Original bug:
https://bugs.openjdk.java.net/browse/JDK-8026303
Original webrev:
http://cr.openjdk.java.net/~jmasa/8026303/webrev.00/
Original changeset:
http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/0ade41b2dbeb
Review:
http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2013-November/008976.html

Thanks,
Stefan









Reply via email to