On 21/02/2019 19:09, Martin Balao wrote: > Hi, > > I'd like to propose the backport of 8204142 [1] to jdk7u. > > * > http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.04.jdk7u/ > * > http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.04.jdk7u.zip > > This patch is already included in mainline [2] and in jdk11u [3]. It has > been proposed for jdk8u [4] and is currently waiting for approval. > Backport was trivial; mostly about replacing lambdas. > > No regressions found in "java/awt/event" test category. > > Can I have an approval? > > Thanks, > Martin.- > > -- > [1] - https://bugs.openjdk.java.net/browse/JDK-8204142 > [2] - http://hg.openjdk.java.net/jdk/jdk/rev/08a0bf1592bd > [3] - http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/f05fb1cc6882 > [4] - > https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-February/008646.html >
I presume you mean a review as this is not a clean backport. A couple of minor issues: 1. Where the lambda usage has been translated into inner classes, can we include @Override annotations for the methods being overridden? 2. I noticed the @key headful tags are being dropped. We should instead backport https://bugs.openjdk.java.net/browse/JDK-8129822 first as was recently done for 8u. 3. Why is the copyright year being bumped? If the intention is to reflect your own changes, I'd suggest it's more appropriate to add a Red Hat copyright line for 2019. Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
