On 14/03/2019 17:20, Martin Balao wrote: > Hi Andrew, > > Thanks for your feedback. Yes, this should have been a Request for > Review instead of Approval. > > Here it's a new version: > > * > http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.05.jdk7u/ > > New: > > * "headful" tags restored > * I proposed a backport of JDK-8129822 to jdk7u here [1] >
Thanks. > * Copyright date restored to the original I think this should really be an addition of a Red Hat 2019 line. > > * Missing @Override added to "evaluate" method > There's a few missing on the run methods in the test cases too (basically places where a lambda has had to be converted) > Kind regards, > Martin.- > > -- > [1] - > https://mail.openjdk.java.net/pipermail/jdk7u-dev/2019-March/010896.html > Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
