Looks good to me now. Thank you Alexey
> On 11 Dec 2020, at 17:12, Sergey Chernyshev <serge.chernys...@bell-sw.com> > wrote: > > Hello Alexey, > > Thanks for pointing this out. I updated the webrev here: > > http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/ > > Thank you. > > > On 11.12.2020 13:17, Alexey Bakhtin wrote: >> Hello Serge, >> >> I see several issues with this patch: >> >> sun/security/ec/ECPrivateKeyImpl.java >> - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can >> be removed >> >> org/jcp/xml/dsig/internal/dom/DOMKeyValue.java >> - DomKeyValue class should be updated to instantiate ECParameters and >> NamedCurve classes in the correct namespace >> This class is modified in the original JDK9 patch [1] but missed in the >> JDK11 and JDK8 because of different XML Dsig implementation. >> >> [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 >> >> Regards >> Alexey > > -- > Best regards, > Sergey Chernyshev > Bellsoft LLC
