Hello Sergey, thanks for the clarification, I see that JDK-8035166 is a prerequisite for JDK-8233228.
The 8u backport for JDK-8035166 has been pushed into jdk8u-dev, and has fixVersion openjdk8u292 (April 2021). Most likely, 8u backport of JDK-8233228 will be available in the same release. It would be natural that these fixes should appear in 7u only after 8u, in April 2021. Unfortunately, at the moment jdk7u does not have a dev repo to accumulate fixes for next release. If you do not mind, I would propose to postpone the push of JDK-8035166 to the April release cycle? What do you think? Thanks, Andrew On 11/12/2020 23:46, Sergey Chernyshev wrote: > Hello Andrew, > > The main goal is to backport JDK-8233228 to 7u, which depends on this issue. > > The same fix was pushed earlier this week to 8u: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b8ad41e9571f > > I am not aware of any 3rd party software that can be affected by the > change. This seems unlikely that the classes moved from sunec.jar to > rt.jar are accessed from anywhere outside OpenJDK. > > Alexey, thank you for review. > > > On 11.12.2020 18:37, Andrew Brygin wrote: >> Hello, >> >> Alexey, thank you for the review. >> >> Sergey, thank you for contributing the fix. Before you push this change >> in 7u, could you please clarify the purpose of this backport? Do you >> plan to backport any followup fixes into 7u? Do you have any assessment >> whether any third-party software could be affected by this change? >> >> Thanks, >> Andrew >> >> On 11/12/2020 17:46, Alexey Bakhtin wrote: >>> Looks good to me now. >>> >>> Thank you >>> Alexey >>> >>>> On 11 Dec 2020, at 17:12, Sergey Chernyshev <serge.chernys...@bell-sw.com> >>>> wrote: >>>> >>>> Hello Alexey, >>>> >>>> Thanks for pointing this out. I updated the webrev here: >>>> >>>> http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/ >>>> >>>> Thank you. >>>> >>>> >>>> On 11.12.2020 13:17, Alexey Bakhtin wrote: >>>>> Hello Serge, >>>>> >>>>> I see several issues with this patch: >>>>> >>>>> sun/security/ec/ECPrivateKeyImpl.java >>>>> - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import >>>>> can be removed >>>>> >>>>> org/jcp/xml/dsig/internal/dom/DOMKeyValue.java >>>>> - DomKeyValue class should be updated to instantiate ECParameters and >>>>> NamedCurve classes in the correct namespace >>>>> This class is modified in the original JDK9 patch [1] but missed in the >>>>> JDK11 and JDK8 because of different XML Dsig implementation. >>>>> >>>>> [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 >>>>> >>>>> Regards >>>>> Alexey >>>> -- >>>> Best regards, >>>> Sergey Chernyshev >>>> Bellsoft LLC >
