> Can you say what tools you used for this, was in an IDE
> or did you run a spell checker by other means?

No, I've used only the words listed in the bug description.
To find all places I used a very simple script mentioned in the bug comments.
But editing should be handled manually, because of the same typos in code.
And for the string literals I will provide additional fix later:
https://bugs.openjdk.java.net/browse/JDK-8026491

> This makes me wonder if you are only doing the jdk repository?

I've handled only the jdk/src without the closed part.

SAM

On 22.10.2013 17:05, Alan Bateman wrote:
On 22/10/2013 13:22, sergey malenkov wrote:
Hello,

Could you please review the following huge fix:
fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/
bug:https://bugs.openjdk.java.net/browse/JDK-8022746

I've replaced all typos with correct words in all documentations and comments. Our technical writer has already checked it.
This is a good work. Can you say what tools you used for this, was in an IDE or did you run a spell checker by other means?

I skimmed through most of the non-client sources and don't see any errors. One comment on jvm.h is that it has a copy in the hotspot repository and that appears to have the same typos. This makes me wonder if you are only doing the jdk repository?

-Alan


Reply via email to