Yes, makes sense to fix now that we know about them On Oct 22, 2013, at 12:45 PM, sergey malenkov wrote:
> Thanks! > I fixed package.html, but there are similar typos in the following classes: > > javax.sql.rowset.spi.XmlReader: > * <code>SyncProvider</code> implementations that supply XML data reader > * capabilities such as output XML stream capabilities can implement this > * interface to provider standard <code>XmlReader</code> objects to > * <code>WebRowSet</code> implementations. > > javax.sql.rowset.spi.XmlWriter: > * <code>SyncProvider</code> implementations that supply XML data writer > * capabilities such as output XML stream capabilities can implement this > * interface to provider standard <code>XmlWriter</code> objects to > * <code>WebRowSet</code> implementations. > > > Should I fix them too? > > ... to provide ... > > Regards, > SAM > > On 22.10.2013 19:39, Lance Andersen - Oracle wrote: >> First, thank you for doing this. >> >> I went through all of the JDBC/RowSet diffs. They all look good but I found >> one other error that the spell checker missed in one of the lines you changed >> >> >> http://cr.openjdk.java.net/~malenkov/8022746.8.0/jdk/src/share/classes/com/sun/rowset/package.html.sdiff.html >> >> 77 classess so that any developer can extend them to provider additional >> features >> >> >> change provider to provide on line 77. >> >> >> Best >> Lance >> On Oct 22, 2013, at 9:05 AM, Alan Bateman wrote: >> >>> On 22/10/2013 13:22, sergey malenkov wrote: >>>> Hello, >>>> >>>> Could you please review the following huge fix: >>>> fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/ >>>> bug:https://bugs.openjdk.java.net/browse/JDK-8022746 >>>> >>>> I've replaced all typos with correct words in all documentations and >>>> comments. Our technical writer has already checked it. >>> This is a good work. Can you say what tools you used for this, was in an >>> IDE or did you run a spell checker by other means? >>> >>> I skimmed through most of the non-client sources and don't see any errors. >>> One comment on jvm.h is that it has a copy in the hotspot repository and >>> that appears to have the same typos. This makes me wonder if you are only >>> doing the jdk repository? >>> >>> -Alan >>> >> >> >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com >> >
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
