So I guess I should ask this now before we go too far to change it:

Given that we had fieldType and fieldTypes in @Field and @Property, and type and types in @Element, @Key, and @Value, I made them consistent by changing types to boundTypes in @Element, @Key, and @Value.

Is this what we want? Or should we change boundTypes back to types for all four annotation types?

Craig

On Jul 25, 2007, at 4:34 PM, Craig Russell (JIRA) wrote:


[ https://issues.apache.org/jira/browse/JDO-510? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel#action_12515454 ]

Craig Russell commented on JDO-510:
-----------------------------------

One more change that we overlooked earlier: change types to boundTypes in @Element, @Key, and @Value to match @Persistent

svn commit
Sending        api2/src/java/javax/jdo/annotations/Column.java
Sending        api2/src/java/javax/jdo/annotations/Element.java
Sending        api2/src/java/javax/jdo/annotations/Embedded.java
Deleting       api2/src/java/javax/jdo/annotations/FetchField.java
Sending        api2/src/java/javax/jdo/annotations/FetchGroup.java
Deleting       api2/src/java/javax/jdo/annotations/Field.java
Deleting api2/src/java/javax/jdo/annotations/ FieldPersistenceModifier.java
Sending        api2/src/java/javax/jdo/annotations/ForeignKey.java
Sending        api2/src/java/javax/jdo/annotations/Index.java
Sending        api2/src/java/javax/jdo/annotations/Join.java
Sending        api2/src/java/javax/jdo/annotations/Key.java
Adding         api2/src/java/javax/jdo/annotations/NotPersistent.java
Sending        api2/src/java/javax/jdo/annotations/Order.java
Sending api2/src/java/javax/jdo/annotations/ PersistenceCapable.java Adding api2/src/java/javax/jdo/annotations/ PersistenceModifier.java
Adding         api2/src/java/javax/jdo/annotations/Persistent.java
Sending        api2/src/java/javax/jdo/annotations/PrimaryKey.java
Deleting       api2/src/java/javax/jdo/annotations/Property.java
Sending        api2/src/java/javax/jdo/annotations/Serialized.java
Sending        api2/src/java/javax/jdo/annotations/Transactional.java
Deleting       api2/src/java/javax/jdo/annotations/Transient.java
Sending        api2/src/java/javax/jdo/annotations/Unique.java
Sending        api2/src/java/javax/jdo/annotations/Value.java
Sending api2/test/java/javax/jdo/annotations/ TestEmbeddedMap.java Sending api2/test/java/javax/jdo/annotations/ TestEmbeddedSet.java
Transmitting file data ....................
Committed revision 559647.
svn commit
Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCAppCompany.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCAppDepartment.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCAppEmployee.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCAppInsurance.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCAppPerson.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCAppProject.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCDSCompany.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCDSDepartment.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCDSEmployee.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCDSPerson.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedFC/FCDSProject.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIAppAddress.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIAppCompany.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIAppDepartment.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIAppEmployee.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIAppInsurance.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIAppPerson.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIAppProject.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIDSCompany.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIDSDepartment.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIDSEmployee.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIDSPerson.java Sending tck2/src/java/org/apache/jdo/tck/pc/ companyAnnotatedPI/PIDSProject.java
Transmitting file data .......................
Committed revision 559648.


Remove @Field and @Property and replace them with @Persistent
-------------------------------------------------------------

                Key: JDO-510
                URL: https://issues.apache.org/jira/browse/JDO-510
            Project: JDO
         Issue Type: New Feature
         Components: api2
           Reporter: Craig Russell
           Assignee: Craig Russell
            Fix For: JDO 2 maintenance release 1

        Attachments: jdo-510.patch, jdo-510.patch


Annotations are different from xml ways that make it impossible to refer to persistent fields and properties in the same way. We started out thinking that we could simply map the xml field to annotations @Field and xml property to @Property but could not refer to multiples in a sane way. This change removes @Field and @Property and replaces them with @Persistent. Other annotations that refer to these are changed so that they refer to members instead of to fields or properties.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to