Re: Company model : concrete classes and use of "field-type"

[Craig L Russell]

Hi,

On Jul 27, 2007, at 9:10 AM, Michael Bouschen wrote:

Hi Craig,

Michelle volunteered to take a look.

Thanks for that.

I think setting the field-type is not necessary, because the declared Java type is Address, a PC class and not an interface. It is ok to specify the field-type, but it might be confusing since it is not necessary. So I propose to remove it.

Craig

I agree that field-type for Address fields is unnecessary and should be removed.

Regards Michael

To your field-type issue, I'll take a look at this later. Do you think it's causing issues?

Craig

On Jul 27, 2007, at 8:30 AM, Andy Jefferson wrote:

Hi Craig,

Looking briefly, it looks like the only cases are for the embedded
Address field. Is this what you are referring to?

That's the one I spotted and didn't look further.




working build
test/java/javax/jdo/annotations/TestEmbeddedSet.java
test/java/javax/jdo/annotations/TestEmbeddedMap.java
- change the "embedded" to "embeddedMapping".



--
Andy  (Java Persistent Objects - http://www.jpox.org)

PS. "api2" seems to be missing a couple of files being checked in for a

Craig Russell

Architect, Sun Java Enterprise System http://java.sun.com/products/ jdo

408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

--
[EMAIL PROTECTED] Engineering GmbH  Tel.: +49/(0)30/235 520-33
Buelowstr. 66                Fax.: +49/(0)30/217 520-12

10783 Berlin mailto:[EMAIL PROTECTED] Geschaeftsfuehrung: Anna-Kristin Proefrock

Sitz Berlin, Amtsgericht Charlottenburg, HRB 564 52

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

smime.p7s
Description: S/MIME cryptographic signature