[ 
https://issues.apache.org/jira/browse/JDO-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195636#comment-13195636
 ] 

Michael Bouschen commented on JDO-647:
--------------------------------------

The patch JDO-647-default-cfgList.patch looks good! 

Just a small comment:
I propose to rethrow the exception when finding configurations.list as 
RuntimeException with the caugth exception as nested exception (see comment // 
Error finding configurations.list). The tck should fail if jdo.tck.cfglist is 
not specified and there is no configurations.list file.
                
> Run TCK using Maven2 for consistency
> ------------------------------------
>
>                 Key: JDO-647
>                 URL: https://issues.apache.org/jira/browse/JDO-647
>             Project: JDO
>          Issue Type: Improvement
>          Components: tck
>    Affects Versions: JDO 3 (3.0)
>            Reporter: Andy Jefferson
>            Assignee: Michelle Caisse
>             Fix For: JDO 3 maintenance release 1 (3.1)
>
>         Attachments: JDO-647-default-cfgList.patch, 
> JDO-647-pom-properties.zip, JDO-647-rootPomChanges.patch, RunRules.patch, 
> api_pom.diff, exectck.zip, exectck.zip, pom.xml, pom.xml
>
>
> Since api2 now builds using Maven2 it makes a heck of a lot of sense to 
> build/run the TCK using that too. It also means that the DataNucleus M1 repo 
> (which only exists for use of this TCK) can be deleted. Please consider 
> upgrading to Maven2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to