clr-apache commented on a change in pull request #33:
URL: https://github.com/apache/db-jdo/pull/33#discussion_r732230250
##########
File path: parent-pom/pom.xml
##########
@@ -41,6 +41,10 @@ Requests (JSR 12 and 243) under the auspices of the Java
Community Process.</des
<url>http://www.apache.org</url>
</organization>
+ <properties>
Review comment:
I think reproducible builds are not required but they are useful.
From the link,
> <project.build.outputTimestamp>1</project.build.outputTimestamp>
Looks like the outputTimestamp can be any arbitrary number and automatically
updated at release time. So I have no objections.
> FAQ
> Q. Can the project.build.outputTimestamp property in pom.xml be updated
automatically at release time?
> A. Yes.
>
> Details depend on your release process tooling:
>
> if you use maven-release-plugin, you'll need version 3.0.0-M1 or later: it
will automatically update the timestamp value in pom.xml during the release in
the same commit that updates version...
>
I'd be interested to see what the value is after you update the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
