tzaeschke commented on a change in pull request #33:
URL: https://github.com/apache/db-jdo/pull/33#discussion_r738648775



##########
File path: parent-pom/pom.xml
##########
@@ -41,6 +41,10 @@ Requests (JSR 12 and 243) under the auspices of the Java 
Community Process.</des
         <url>http://www.apache.org</url>
     </organization>
 
+    <properties>

Review comment:
       > Looks like the outputTimestamp can be any arbitrary number and 
automatically updated at release time. So I have no objections.
   
   I had to put in a fully formatted time stamp because maven-javadoc-plugin 
(3.3.0) has a bug such that it fails when a simple number is given. This is 
fixed in 3.3.1, but for some reason I have to enforce 3.3.1 with an extra entry 
in the `pom`, otherwise it runs (and fails) with 3.3.0.
   
   I have removed it for now. For reproducible builds we would also (as I 
understand it) need to fixate all dependencies with a specific version. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to