Attendees: Michael Bouschen, Tilmann Zäschke, Craig Russell

Next meeting: Thursday March 9 1100 PST 2000 CET

Agenda:

1. JIRA JDO-819 "Code quality analysis" 
https://issues.apache.org/jira/browse/JDO-819
   JIRA JDO-823 "Fix sonarcloud issues of type Code Smells" 
https://issues.apache.org/jira/browse/JDO-823

Sonarcloud link: https://sonarcloud.io/summary/overall?id=db-jdo

* Try-catch blocks should not be nested:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1141&severities=MAJOR&id=db-jdo

JDOHelper.getEnhancer method should be rewritten

InstallSchema.loadSQLFileUsingJDBC method should be rewritten.

Volunteer: Tilmann

* Utility classes should not habe public constructors:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1118&severities=MAJOR&id=db-jdo
JDOHelper should not have a public constructor but is a breaking change, as 
JDOHelper is a public class.
Resolution: "don't fix" until we have a "breaking change" release.

LegacyJava should not have a public constructor.
AI Michael change to a private constructor

PropertyUtils should not have a public constructor.
AI Michael change to a private constructor

* Sections of code should not be commented out:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS125&severities=MAJOR&id=db-jdo
* Throwable and Error shoudl not be caught:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1181&severities=MAJOR&id=db-jdo
* Constructors of an abstract" class should not be declared "public":
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS5993&severities=MAJOR&id=db-jdo
* Cognitive Complexity of methods should not be too high:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3776&severities=CRITICAL&types=CODE_SMELL&id=db-jdo
* Raw types should not be used:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3740&severities=MAJOR&id=db-jdo

2. JIRA JDO-709 "Standardize field/property converters" 
https://issues.apache.org/jira/browse/JDO-709

3. JIRA JDO-822: "Verify compatibility with JDK 20" 
https://issues.apache.org/jira/browse/JDO-822

4. JIRA JDO-812 "Move to JDK 11 as the lowest supported version" 
https://issues.apache.org/jira/browse/JDO-812

5. Other issues

Action Items from weeks past:

[Nov 23 2022] AI Tilmann follow up with Andy/DataNucleus for his advice on 
JDO-709.
[Oct 20 2022] AI Craig update the JIRA JDO-709 to request a test case using 
annotations and results of the test.
[Dec 09 2021] AI Craig: Try to contact all current/former participants in JDO 
development and see if and how they want to be recognized on the JDO and DB web 
sites.https://db.apache.org/whoweare.html
[Oct 07 2021] AI Craig send a private message to all JSR-243 Expert Group 
members asking if they wish to continue.
[Mar 25 2021] AI Craig: investigate "merging" papajdo and apache.clr accounts
[Oct 17 2014] AI Matthew any updates for "Modify specification to address NoSQL 
datastores" https://issues.apache.org/jira/browse/JDO-651

Reply via email to