mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387254461
##########
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##########
@@ -528,13 +693,14 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
+ File.separator;
String[] metadataExtensions = {"jdo", "jdoquery", "orm", "xml",
"properties"};
String fromFileName = null;
+ File toFile = null;
String pkgName = null;
int startIdx = -1;
// iterator over list of abs name of metadata files in src
Iterator<File> fi = FileUtils.iterateFiles(new File(fromDirName),
metadataExtensions, true);
while (fi.hasNext()) {
try {
- fromFile = fi.next();
+ File fromFile = fi.next();
Review Comment:
- I agree the try clause should only contain the FileUtil.copy
- The files should be copied, because the enhanced directory should be kept
in case you want to run the next tck run without enhacement.
- I agree to declare the variables in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
