mboapache commented on code in PR #85: URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350
########## tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java: ########## @@ -35,29 +36,23 @@ public class IsDetached extends DetachTest { private static final String ASSERTION_FAILED = "Assertion A8.5.6-1 JDOHelper.isDetached(Object) failed: "; - /** - * The <code>main</code> is called when the class is directly executed from the command line. - * - * @param args The arguments passed to the program. - */ - public static void main(String[] args) { - BatchTestRunner.run(IsDetached.class); - } - + @Test public void testNullTransientAndUndetachableIsDetachedFalse() { pm = getPM(); pm.currentTransaction().begin(); - assertFalse(ASSERTION_FAILED + "null object is detached", JDOHelper.isDetached(null)); - assertFalse( - ASSERTION_FAILED + "transient object is detached", JDOHelper.isDetached(new Cart("bob"))); - assertFalse( - ASSERTION_FAILED + "object of class marked not detachabled is detached", - JDOHelper.isDetached(new Undetachable())); + Assertions.assertFalse( Review Comment: For me this is a preferred style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org