Thanks, Lace... Updated, please review...
Thanks, Henry Laszlo (Laca) Peter ??: > On Wed, 2008-09-03 at 16:18 +0800, Henry Zhang wrote: >> # >> # spec file for package SUNWgkrellm >> # >> # Copyright (c) 2006 Sun Microsystems, Inc. > > year += 2; > >> # This file and all modifications and additions to the pristine >> # package are under the same license as the package itself. >> # >> # Owner: Henry >> # > > Is this your opensolaris.org user name? > >> %include Solaris.inc >> >> %define SUNWgnugettext %(/usr/bin/pkginfo -q SUNWgnu-gettext && >> echo 1 || echo 0) > > You can remove this, and the references to SFEgettext below, too. > >> Name: SUNWgkrellm >> Summary: Popular (ubiquitous) Gtk-based system monitor >> Version: 2.3.1 >> Source: >> http://members.dslextreme.com/users/billw/gkrellm/gkrellm-%{version}.tar.bz2 > >> Patch1: gkrellm-01-ldflags.diff >> Patch2: gkrellm-02-manpage.diff > > Add patch comments please. > >> SUNW_BaseDir: %{_basedir} >> SUNW_Copyright: %{name}.copyright >> BuildRoot: %{_tmppath}/%{name}-%{version}-build >> %include default-depend.inc >> >> %if %SUNWgnugettext >> Requires: SUNWgnu-gettext >> %else >> BuildRequires: SFEgettext-devel >> Requires: SFEgettext >> %endif > > You can leave Requires: SUNWgnu-gettext there. > >> %if %option_with_fox >> Requires: FSWxorg-clientlibs >> Requires: FSWxwrtl >> BuildRequires: FSWxorg-headers > > This is no longer needed. > >> %else >> Requires: SUNWxorg-clientlibs >> # Guarantee X/GTK/freetype environment, concisely (hopefully) >> BuildRequires: SUNWGtku >> # The above causes many things to get pulled in > > Whoa, is this a gtk 1.2 app? > >> BuildRequires: SUNWxwplt >> # The above brings in many things, including SUNWxwice and SUNWzlib >> BuildRequires: SUNWxwxft >> # The above also pulls in SUNWfreetype2 >> >> Requires: SUNWGtku >> Requires: SUNWxwplt >> Requires: SUNWxwxft >> %endif >> Requires: SUNWlexpt >> Requires: SUNWmlib >> Requires: SUNWpng >> Requires: SUNWopenssl-libraries >> >> >> %package devel >> Summary: %{summary} - development files >> SUNW_BaseDir: %{_basedir} >> %include default-depend.inc >> Requires: %name >> >> %prep >> %setup -q -n gkrellm-%version >> %patch1 -p1 >> %patch2 -p1 >> >> %build >> CPUS=`/usr/sbin/psrinfo | grep on-line | wc -l | tr -d ' '` >> if test "x$CPUS" = "x" -o $CPUS = 0; then >> CPUS=1 >> fi >> >> export CFLAGS="-O4 -fPIC -DPIC -Xlinker -i -fno-omit-frame-pointer" > > These are gcc CFLAGS. Does this package require gcc? > >> %if %option_with_fox >> export CFLAGS="$CFLAGS -I/usr/X11/include" >> %endif > > We don't need the %option_with_fox stuff. > > Laca > > -------------- next part -------------- A non-text attachment was scrubbed... Name: SUNWgkrellm.spec Type: text/x-rpm-spec Size: 3424 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080905/bb58c6d1/attachment.bin>
