Henry,

Much better, more comments below:

On Fri, 2008-09-05 at 13:25 +0800, Henry Zhang wrote:
> Name:                SUNWgkrellm
> Summary:             Popular (ubiquitous) Gtk-based system monitor
> Version:             2.3.1
> Source:              
> http://members.dslextreme.com/users/billw/gkrellm/gkrellm-%{version}.tar.bz2
> # date:2008-09-4 owner:henryz type:bug bugster: bugzilla:
> Patch1:              gkrellm-01-ldflags.diff

If you don't have bugids, don't include empty bugster: and bugzilla:
comments, but you really should have bugids.

> # date:2008-09-4 owner:henryz type:bug bugster: bugzilla:
> Patch2:              gkrellm-02-manpage.diff
> # date:2008-09-4 owner:henryz type:feature bugster: bugzilla:
> Patch3:              gkrellm-03-battery.diff
> SUNW_BaseDir:        %{_basedir}
> SUNW_Copyright:      %{name}.copyright
> BuildRoot:           %{_tmppath}/%{name}-%{version}-build
> %include default-depend.inc
> 
> Requires: SUNWgnu-gettext
> 
> Requires: SUNWxorg-clientlibs
> # Guarantee X/GTK/freetype environment, concisely (hopefully)
> BuildRequires: SUNWGtku

You didn't answer the question about Gtk 1.2, but I checked
the gkrellm web page and it says that it requires glib 2.0
gtk 2.0, gdk 2.0, so you don't need SUNWGtku, but you do 
need SUNWgnome-base-libs[-devel].

> # The above causes many things to get pulled in
> BuildRequires: SUNWxwplt 
> # The above brings in many things, including SUNWxwice and SUNWzlib
> BuildRequires: SUNWxwxft 
> # The above also pulls in SUNWfreetype2
> 
> Requires: SUNWGtku
> Requires: SUNWxwplt 
> Requires: SUNWxwxft 

SUNWgnome-base-libs already depends on the X libs so you don't
need those.

> Requires: SUNWlexpt

> Requires: SUNWmlib
> Requires: SUNWpng

SUNWgnome-base-libs also depends on SUNWmlib and SUNWpng.

> Requires: SUNWopenssl-libraries
> 
> 
> %package devel
> Summary:                 %{summary} - development files
> SUNW_BaseDir:            %{_basedir}
> %include default-depend.inc
> Requires: %name
> 
> %prep
> %setup -q -n gkrellm-%version
> %patch1 -p1
> %patch2 -p1
> %patch3 -p1
> 
> %build
> CPUS=`/usr/sbin/psrinfo | grep on-line | wc -l | tr -d ' '`
> if test "x$CPUS" = "x" -o $CPUS = 0; then
>      CPUS=1
> fi
> 
> export LDFLAGS="%arch_ldadd %ldadd ${EXTRA_LDFLAGS} -L/usr/sfw/lib 
> -R/usr/sfw/lib"
> export LD_OPTIONS="-L/usr/sfw/lib -R/usr/sfw/lib"
> 
> make -j$CPUS solaris
> 

Please use the optimization flags (%optflags) too.

Laca



Reply via email to