Hi Ginn, Thanks for the reviews. I've tracked these two patches in GNOME bugzilla: 543369. And the patch 03 is caused by the strange behavior for "pcre-config --cflags" which is supposed to have the output "-I/usr/include/pcre". Have contacted with the pcre owner for this, also tried to replace pcre-config with pkg-config in the community.
Attaches are the update version. -Alfred Ginn Chen wrote: > 1) bluefish-01-debug_func.diff > You should define DEBUG_MSG as empty when DEBUG is not defined. > > 2) bluefish-03-pcre-devel.diff > You should add > pkg-config --cflags libpcre > to compile line rather than change the source code. > > Ginn > > On Jul 16, 2008, at 11:14 PM, Alfred Peng wrote: > >> Hi, >> >> Please help me review the spec file for Bluefish. SUNWbluefish.spec >> will be in spec-files-other/core. >> >> Thanks, >> -Alfred -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: bluefish-01-no-debug.diff URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080718/bdf7350f/attachment.ksh> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: bluefish-02-update-mime.diff URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080718/bdf7350f/attachment-0001.ksh> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: bluefish-03-pcre-cflags.diff URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080718/bdf7350f/attachment-0002.ksh> -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: SUNWbluefish.spec URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080718/bdf7350f/attachment-0003.ksh>
