Alfred,

What Ginn said, plus some more comments inline:

On Wed, 2008-07-16 at 23:14 +0800, Alfred Peng wrote:
> #
> # spec file for package SUNWbluefish
> #
> # Copyright 2008 Sun Microsystems, Inc.
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> 
> # includes module(s): bluefish
> #
> %include Solaris.inc
> 
> Name:                    SUNWbluefish
> Summary:                 Bluefish, a powerful editor for experienced
> web designers.
> Version:                 1.0.7
> Source:
> http://www.bennewitz.com/bluefish/stable/source/bluefish-%{version}.tar.bz2
> URL:                     http://bluefish.openoffice.nl/index.html
> SUNW_Copyright:          SUNWbluefish.copyright
> 
> # owner:alfred date:2008-07-16 type:bug
> Patch1:                  bluefish-01-debug_func.diff
> # owner:alfred date:2008-07-16 type:branding
> Patch2:                  bluefish-02-update-mime.diff
> # owner:alfred date:2008-07-16 type:branding
> Patch3:                  bluefish-03-pcre-devel.diff
> SUNW_BaseDir:            %{_basedir}
> BuildRoot:               %{_tmppath}/%{name}-%{version}-build
> %include default-depend.inc
> Requires: SUNWpcre
> Requires: SUNWgnome-spell
> Requires: SUNWgnome-libs
> BuildRequires: SUNWgnome-libs-devel
> Requires: SUNWlibC

Is it C++ code?  Do you need to define CXXFLAGS?

Also, you need a dependency on SUNWpostrun since you use a
postrun script.

> export CFLAGS="%optflags -I/usr/gnu/include -I/usr/sfw/include
> -DANSICPP"
> export CPPFLAGS="-I/usr/sfw/include"
> export LDFLAGS="-L/usr/sfw/lib -R/usr/sfw/lib -L/usr/gnu/lib
> -R/usr/gnu/lib"

Does it actually use anything that is still in /usr/sfw?
It's mostly empty now with just compatibility symlinks.

> ( echo 'test -x %{_bindir}/update-mime-database || exit 0';
>   echo '%{_bindir}/update-mime-database %{_datadir}/mime'
> ) | $PKG_INSTALL_ROOT/usr/lib/postrun -b -u

The last line should be:

) | $BASEDIR/lib/postrun -b -u -c JDS_wait

Which means that the GNOME session needs wait for this task
to complete.
                                        }
> bluefish-1.0.5/data/Makefile.in.orig  2006-02-10 18:03:19.392428000
> +0000
> +++ bluefish-1.0.5/data/Makefile.in   2006-02-10 18:13:28.694247000
> +0000
> @@ -58,14 +58,14 @@
>       $(INSTALL_DATA) bluefish-project.desktop $(DESTDIR)$(FDMENU)
>  
>  install-update-menu:
> -     $(UPDATE_DESKTOP)
> +     # $(UPDATE_DESKTOP)
>  
>  install-fdmime:
>       $(INSTALL_DIR) $(DESTDIR)$(FDMIME)/packages
>       $(INSTALL_DATA) bluefish.xml $(DESTDIR)$(FDMIME)/packages
>  
>  install-update-mime:
> -     $(UPDATE_MIME) $(FDMIME)
> +     # $(UPDATE_MIME) $(DESTDIR)$(FDMIME)
>  
>  install-gnome-2.4-mime:
>       $(INSTALL_DIR) $(DESTDIR)$(GMIMEINFO)

There is often a configure option for disabling this -- you
shouldn't need to patch it.  If not, you can still define
UPDATE_DESKTOP as empty:

make install UPDATE_DESKTOP=/bin/true UPDATE_MIME=/bin/true

Laca



Reply via email to