Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: f4c4a3c311028b27572f43932d88440d976e34a8
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/f4c4a3c311028b27572f43932d88440d976e34a8
Author: Pavel Roskin <[email protected]>
Date: 2019-06-26 (Wed, 26 Jun 2019)
Changed paths:
M README.md
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildEnvironmentContributor.java
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashCause.java
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
M
src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java
Log Message:
-----------
Fill parameter values from environment variables added by the plugin
Parameters generate environment variables that take precedence over the
environment variables supplied by the EnvironmentContributor extension.
Some users relied on the plugin filling values for the parameters defined
for the project. That functionality was broken in version 1.9.
Make StashRepository#getParameters() fill parameters with the values that
the plugin supplies to the environment.
To avoid code duplication, move the environment variables to StashCause
as a transient map (the data is already saved to XML files from the
fields). Use that map both from StashBuildEnvironmentContributor and
StashRepository.
Make the environment variables override the parameters from the pull
request comments. Users with comment posting permissions should not be
able to override parameters that the administrator intended to be filled
from the environment.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/302f76-f4c4a3%40github.com.
For more options, visit https://groups.google.com/d/optout.
