Branch: refs/heads/master
Home: https://github.com/jenkinsci/ec2-plugin
Commit: 08c32fe75cafd35a0f255c23a4c565959454553d
https://github.com/jenkinsci/ec2-plugin/commit/08c32fe75cafd35a0f255c23a4c565959454553d
Author: Ryan Slobojan <[email protected]>
Date: 2020-04-29 (Wed, 29 Apr 2020)
Changed paths:
M src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java
Log Message:
-----------
[JENKINS-62043] Fix NPE which broke Jenkins builds (#452)
* [JENKINS-62043] Fix NPE which broke Jenkins builds
In PR #433, which was released in AWS EC2 Plugin 1.50, a bug was introduced due
to improper handling of an
important transient field which is accessed very frequently by the Jenkins
server due to it being referenced in
`EC2AbstractSlave.isAcceptingTasks()`. This broke any Jenkins user which had
running EC2 Nodes during the
update to plugin 1.50 (see https://issues.jenkins-ci.org/browse/JENKINS-62043
for details).
* Excluded false-positive nullcheck Spotbugs rule
Turned off a Spotbugs rule which incorrectly understands how Java serialization
works, and which thought a transient field
couldn't be null in Object.readResolve() when it actually can be.
* Removed @Nonnull annotation from transient field
Removed a javax.annotation.Nonnull annotation from a transient field to silence
a Spotbugs warning which
incorrectly flagged a field as never being null when it can in fact be null due
to Java serialization semantics
* Removed unneeded NONNULL exclusion
Code in EC2AbstractSlave was updated to remove a javax.annotation.Nonnull
annotation, so this Spotbugs warning should
no longer trigger and we can remove the exclusion.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/ec2-plugin/push/refs/heads/master/e4d2a5-08c32f%40github.com.
