On 04/26/2012 07:09 AM, Christoph Kutzinski wrote:
Hi,

in case no one else has mentioned, there are currently a lot of
complaints and a lively discussion in https://issues.jenkins-ci.org
/browse/JENKINS-11381 why Jenkins still doesn't support svn 1.7 now
that SVNKit 1.7 is released.

Indeed, I missed that. I just imported SVNKit 1.7.4, and updated Subversion plugin accordingly. I've posted the RC of the new Subversion plugin to JENKINS-11381, and deployed it to ci.jenkins-ci.org.

I'll wait for a few more days before releasing this as 1.40.


I would fix this myself, but I don't know what the Jenkins specific
patches to SVNKit are and how to apply them to SVNKit 1.7

There's the 'incoming' branch that keeps the pristine unmodified upstream source code, then there's the master branch that keeps track of the locally maintained version.

So to bump up the dependency, the process involves:

1. checking out the incoming branch
2. wipe out the working copy (so that we won't have any left-over files
   that are deleted in the upstream.)
3. get the pristine source tree of the upstream at a released version
4. commit this new tree.
5. merge the incoming branch into the master branch, resolving
   conflicts. for conflicts, "git annotate" tells you the context
   of changes.
6. 'git diff incoming master' gives you the current changes.



I'd like to take this opportunity to point out again that using a
patched library is *NOT* a good idea and we should try to see how the
Hudson guys solved it in this case.

There's no disagreement there, but those changes are there for reasons, and it takes some efforts to push them upstream.

I looked at the current diff [1] and there are several things here:

- remoting related changes: making classes serializable, and recording
  keys by its content, not by file name.
- hook mechanism in the authentication.
- error handling improvement, where SVNKit tends to throw away some
  details.
- authentication related bug fixes.

Let me post this to the upstream and get the conversation started...



cheers
Christoph
.


[1] https://github.com/jenkinsci/svnkit/compare/incoming...master
--
Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/
Try Nectar, our professional version of Jenkins

Reply via email to