On 09/21/2012 10:20 AM, Jesse Glick wrote:
On 09/20/2012 05:20 PM, Kohsuke Kawaguchi wrote:
We can create a pull request from one branch to another, so if that's the only
thing, I'd encourage you to create a branch.
No, my point was really that it is hard to _comment_ on changes made in a
branch which is not a pull request. You have to either use the mailing list,
which is awkward;
or look up the commit that introduced that line and comment on it, which is a
pain, and will not work well if and when the comment is addressed.
I created https://github.com/jenkinsci/jenkins/pull/573 to keep track of
this. IIUC, I think we both now agree that there's no downside to doing
this as a branch as opposed to do this in a personal repository.
Wrt line comment on aggregated diff, I don't know what will happen when more
commits are added --- I suspect they'll get lost.
No, they continue to be displayed in the diff tab unless and until a commit
changes the lines that were commented on—at which point the discussion tab of
the pull request
shows that there were some obsolete comments at a particular point. This makes
it easy for the author of the pull request to see at a glance all the details
that might
still need to be addressed according to reviewers.
--
Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/
Try Nectar, our professional version of Jenkins
