Jesse, Your proposal is much more cleaner, mine was just a hack to see if I could actually get transparent artifact compression to work. I am going through your implementation and I see you have an abstract ArtifactManager class and if I understand correctly your idea is to allow a plugin to provide its own implementation of this class. I have a few questions though.
When there are multiple ArtifactManagers, how does Jenkins choose which one should be used for the build (maybe have an ArtifactManager return a priority number and have Jenkins loop though available ArtifactManagers in order of priority and return the first one that returns true for the appliesTo method?) The other question is that since the getArtifactsDir returns a File object (I see that this has been deprecated now), how do we make existing plugins like the copyartifacts plugin work as I think they depend on this method. On Mon, Jun 17, 2013 at 4:34 AM, Jesse Glick <[email protected]> wrote: > On 06/14/2013 01:41 PM, vimil saju wrote: > >> I added a new Interface called ArtifactAction. this interface has a >> method call getArtifactsDir(). >> I modified the getArtifactsDir() method in hudson.model.Run.java to first >> check if the Run Object has any action that implements ArtifactAction >> interface. If such an >> action is present then its getArtifactsDir method is called otherwise the >> default artifacts location is returned >> > > My proposed implementation of JENKINS-17236 [1] should be more general, I > think. Was originally trying to get it into the current LTS but ran out of > time. Need to resume work on it. > > > [1] > https://github.com/jenkinsci/**jenkins/pull/736<https://github.com/jenkinsci/jenkins/pull/736> > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to > jenkinsci-dev+unsubscribe@**googlegroups.com<jenkinsci-dev%[email protected]> > . > For more options, visit > https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> > . > > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
