It's my bad, It was one test case that I was unable to do when I made that change in stapler and of course it came back and bit me. On modern browsers the json2 lib isn't needed at all because it is included the standard Javascript api, but older browsers needs it to be able to serialize to json, HTMLUnit is one of those so without it tests won't run as expected. Prototype has its own implementation but jQuery doesn't have one. At the specific time where the adjuct for it is called stapler doesn't know if it is needed or not. So I'm not sure how I could fix it in stapler, where it should be fixed.
One way to solve it in Jenkins would be to add the adjunct tag for the json2 script somewhere at the top in the header of layout.jelly, then it would be ignored at the first st:bind tag because the adjunct manager has already included it earlier on the page. Robert Sandell Software Tools Engineer - SW Environment and Product Configuration Sony Mobile Communications From: [email protected] [mailto:[email protected]] On Behalf Of Jan Molak Sent: den 1 augusti 2013 01:48 To: [email protected] Subject: RE: JENKINS-18641: Changes to Stapler's JavaScript proxy will break plugins depending on it Dear all, It seems that https://github.com/stapler/stapler/commit/48cdf0f3242c6a79bb398e9115c0db7526c42a50 changeset committed to Stapler introduces following issues when Jenkins is used together with the jQuery plugin: 1) <st:bind /> tag no longer works as advertised in the manual (https://wiki.jenkins-ci.org/display/JENKINS/AJAX+with+JavaScript+proxy), generating an additional <script> tag that's trying to include json2.js file, instead of just simply generating a makeStaplerProxy(...) - there's a ticket raised for this already in Jira: https://issues.jenkins-ci.org/browse/JENKINS-18641 2) this will affect any Jenkins plugin that's running on Jenkins > 1.521 with jquery-plugin installed that relies on makeStaplerProxy(...) 3) this changeset also breaks the "People" page on Jenkins (please see the attached screenshot) Even though a fix for 3) is proposed here: https://github.com/jenkinsci/jenkins/commit/8c8219114dcfd5bb2b63715f6aa33465a584a91b, it only addresses a symptom, not the route cause of the problem (Stapler). All the plugins that rely on makeStaplerProxy will still be affected when the jQuery plugin is present. May I suggest that 48cdf0f3242c6a79bb398e9115c0db7526c42a50 changeset to Stapler is rolled back? I'm also happy to help fixing this issue, since it's affecting my Build Monitor plugin<https://wiki.jenkins-ci.org/display/JENKINS/Build+Monitor+Plugin> as well :) Kind regards, Jan -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]<mailto:[email protected]>. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
