2013/9/3 Oleg Nenashev <[email protected]> > Hello, > > Probably, you could add custom-tools as a dependency in order to prevent > duplication of DecoratedLauncher. >
I think it would be even better to move it to core. nodejs also use a copy-paste for this class > Usage of @buildEnvVars(EnvVars env) is a real hack, but I don't see > alternate solution as well :( > > BTW, it would be great to have an additional extension point in the > custom-tool in order to simplify implementation of a new tools. > > Best regards, > Oleg Nenashev > > вторник, 3 сентября 2013 г., 0:15:49 UTC+4 пользователь nicolas de loof > написал: >> >> inspired by other plugins (custom-tools, nodejs) I've added a >> DecoratedLauncher to convert proc.env into EnvVar, then let the >> ToolInstallation post-process, then re-convert into env. >> Looks os hacky I wonder there isn't a better way ... >> >> https://github.com/ndeloof/**bees-sdk-plugin/commit/** >> 63eff4b438fe2c330482f61aa2cb83**28ebdb832f<https://github.com/ndeloof/bees-sdk-plugin/commit/63eff4b438fe2c330482f61aa2cb8328ebdb832f> >> >> >> 2013/9/2 nicolas de loof <[email protected]> >> >> Hi, >>> I'm working on >>> https://github.com/ndeloof/**bees-sdk-plugin<https://github.com/ndeloof/bees-sdk-plugin> >>> plugin manage a ToolInstaller and a BuildWrapper to expose tool in PATH >>> >>> to know tool installation folder, I need AutoInstaller to have installed >>> the tool, so I moved it to decorateLauncher >>> - but it's seem it's to late to contribute environment with PATH+FOO hack >>> >>> Any guidance on contributing to PATH environment from a ToolInstaller >>> would be appreciated >>> >>> I also wonder my ToolInstallations aren't persisted. I added save() and >>> load() to my ToolDescriptor, seems odd having to do this. >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
