Wasn't the whole reason to rename the artifactId to keep compatibility
with the existing Play plugin?
As Domi mentioned, ideally, existing users should be able upgrade
seamlessly when you publish your version of the plugin.
So I believe the artifactId should remain the same
("play-autotest-plugin"), and the new plugin should migrate any old
config where appropriate.
On 08/17/2014 01:51 AM, Rafael Ribeiro Rezende wrote:
Or we could take the chance and fix this one at least... But I don't
know if it would break any reference.
On Aug 16, 2014 3:56 PM, "Daniel Beck" <[email protected]
<mailto:[email protected]>> wrote:
More than 150 plugins do it wrong (i.e. have a name ending in
-plugin), so that's not something to be concerned about.
On 16.08.2014, at 14:57, Rafael Ribeiro Rezende
<[email protected] <mailto:[email protected]>> wrote:
> Agreed, but the old pom.xml already had the "-plugin" in its
artifactId.
>
> If I remove it in this case, the ids won't match anymore.
> Ideas?
>
> On Aug 16, 2014 2:47 PM, "[email protected]
<mailto:[email protected]>" <[email protected]
<mailto:[email protected]>> wrote:
> the artefactId is taken from the pom.xml (which should not
contain "-plugin") - the name of the git repository per convention
is like <artifactId>-plugin
> Domi
>
> On 16 Aug 2014, at 00:37, Rafael Ribeiro Rezende
<[email protected] <mailto:[email protected]>> wrote:
>
>> Thanks for pointing that out.
>> I just noticed that the artifactId is actually
play-autotest-plugin instead of the play-plugin I assumed at first
due to the folder name in the jenkinsci Github.
>>
>> Just fixed the artifactId to match the older one.
>>
>>
>> On Fri, Aug 15, 2014 at 11:54 PM, domi <[email protected]
<mailto:[email protected]>> wrote:
>> If the old one is not working anymore, then you should integrate
your stuff into it and try to migrate the old config to the new one,
this will keep the plugin with the same pluginid and
>> It will keep the users from scratching there head when searching
for "the right Play-Plugin"
>>
>> Am 15.08.2014 um 14:59 schrieb Rafael Ribeiro Rezende
<[email protected] <mailto:[email protected]>>:
>>
>>> Hello everyone,
>>>
>>> I finally managed some time to finish and test the new Play plugin.
>>> The Play!Framework plugin is designed to work with every
existing version of Play, from the first non-sbt-based Play!1.x to
the latest versions of Activator.
>>>
>>> Some important details before publishing:
>>> There is an existing play-plugin in the public repository that
served the purposed in the past but isn't supported since 2011.
Play! has changed quite a lot since then, so that this play-plugin
is no longer functional.
>>>
>>> I've contacted the previous contributor, Takafumi Ikeda, and he
was very open to the idea of replacing his plugin.
>>> Therefore, I forked the original plugin o Github, but ended up
re-developing it from scratch.
>>> This is the current candidate plugin in my Github.
>>>
>>> What should I do next?
>>>
>>> --
>>> You received this message because you are subscribed to the
Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from
it, send an email to [email protected]
<mailto:jenkinsci-dev%[email protected]>.
>>>
>>> For more options, visit https://groups.google.com/d/optout.
>>
>> --
>> You received this message because you are subscribed to a topic
in the Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit
https://groups.google.com/d/topic/jenkinsci-dev/adzmHYHaeeA/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email
to [email protected]
<mailto:jenkinsci-dev%[email protected]>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>>
>> --
>> Rafael R Rezende
>>
>> --
>> You received this message because you are subscribed to the
Google Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from
it, send an email to [email protected]
<mailto:jenkinsci-dev%[email protected]>.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to a topic
in the Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
https://groups.google.com/d/topic/jenkinsci-dev/adzmHYHaeeA/unsubscribe.
> To unsubscribe from this group and all its topics, send an email
to [email protected]
<mailto:jenkinsci-dev%[email protected]>.
> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the
Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected]
<mailto:jenkinsci-dev%[email protected]>.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in
the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/jenkinsci-dev/adzmHYHaeeA/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
[email protected]
<mailto:jenkinsci-dev%[email protected]>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected]
<mailto:[email protected]>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
