Bump! Could anyone please review the suggested plug-in (and eventually approve commit access for jenkins repository)?
On Wed, Dec 17, 2014 at 1:24 PM, Rocky Stone <[email protected]> wrote: > Thanks Daniel for replying to Slide, you have explained it better that I > would have :) > > And thanks the valuable feedback, it is very welcome! > > I renamed the plugin to Distinguishable Gray Balls > <https://github.com/kralq/distinguishable-gray-balls-plugin>, renamed the > package name and updated the logger. > > On Tue, Dec 16, 2014 at 8:46 PM, Daniel Beck <[email protected]> wrote: >> >> I had the same initial reaction. However, note that this plugin retains >> the blue balls. It just does something similar with to the grey balls only >> (i.e. likely a similar implementation, which isn't a great indicator WRT >> which plugins should be combined). While Green Balls deals with the >> blue/green (and in per-user color-blind mode yellow and red) balls, this >> one processes the grey balls only. 'Fork' in this case just means "I copied >> a bunch of code". >> >> And if these were merged, you'd need several new global options: >> >> * Blue or green (in the former case, no color blindness options should be >> offered to users) >> * Differentiate between aborted, disabled and not built Y/N >> >> The well-established name 'Green Balls' would also become somewhat >> misleading as it wouldn't cover half the feature set. >> >> It'd just be a mess. >> >> --- >> >> That said, 'job-status-icons-plugin' seems a bit too generic. It doesn't >> tell you anything about what it does. Since the author appears to not want >> to extend the feature set a lot beyond what it already does, >> 'distinguishable-grey-icons' or something might be better. >> >> And while I'm nitpicking, this line should also be changed: >> >> https://github.com/kralq/job-status-icons-plugin/blob/master/src/main/java/hudson/plugins/statusicons/StatusIconFilter.java#L30 >> >> On 16.12.2014, at 19:29, Slide <[email protected]> wrote: >> >> > Why do you prefer not to merge it with Green Balls? If the plugins >> basically have the same root, I think it would be better to merge into an >> existing plugin rather than creating a new one. >> > >> > On Tue Dec 16 2014 at 11:09:00 AM Rocky Stone <[email protected]> >> wrote: >> > Hi Jenkins Devs, >> > >> > I would like to add a plugin forked from Green Balls that adds icons >> for Disabled and Aborted job status. >> > >> > GitHub plugin name: job-status-icons-plugin >> > Personal GitHub ID: kralq >> > Existing GitHub repository: >> https://github.com/kralq/job-status-icons-plugin >> > >> > IMHO it's best to update the default Jenkins icons, and I'll be happy >> if the Jenkins developers consider using the very simple icons I created >> based on the gray ball icon. >> > >> > The plugin will still be useful for people that aren't using the latest >> and greatest (e.g. on the LTS release channel), so I would like to publish >> it even if the default Jenkins icons get updated. >> > >> > I read in the wiki that it's best to contribute to existing plugins >> rather than creating new ones, but this contradicts to the KISS principle. >> So even though I basically copied the Green Balls plugin and updated the >> svg icons I prefer not to merge it with Green Balls. Moreover the plugin is >> compatible with both blue and green success status icon. >> > >> > Thanks, >> > Rocky >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups "Jenkins Developers" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to [email protected]. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAHZdiZGO7B3OTjvy%3DQCdBwBKZCH-xtiTkdpbX2fORJV9-e0%3DKw%40mail.gmail.com >> . >> > For more options, visit https://groups.google.com/d/optout. >> > >> > -- >> > You received this message because you are subscribed to the Google >> Groups "Jenkins Developers" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> an email to [email protected]. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVeozW2HM7whAN4hoANQg8RTjD9kH2R-T7tzJofUGNPrrw%40mail.gmail.com >> . >> > For more options, visit https://groups.google.com/d/optout. >> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/FiTLz6TDSL4/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/4ED9F5B2-11F8-4FAB-BCE2-8BF6B0503716%40beckweb.net >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAHZdiZF9XJC1sEYGOeqxSPM5LYj_V-%3D%2BXH99HRh3N%3DuMmrZ4fw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
