I can turn on the findbugs goal for you in the job if you like (that's one of the new checkboxes I added).
/B On Thu, Jul 2, 2015 at 8:05 PM, Mark Waite <[email protected]> wrote: > It looks like I was wrong. I thought the two plugins were configured to > generate findbugs reports with the "install" goal. As far as I can see > from the jobs I run on my own server, I'm explicitly using the "findbugs" > goal. I'll need to investigate further before the > jenkins.ci.cloudbees.com job will show results for those two plugins. > > Mark Waite > > On Thu, Jul 2, 2015 at 11:28 AM Robert Sandell <[email protected]> > wrote: > >> If it's configured to run when you do mvn install it should be picked up >> automagically as long as xmlOutput is configured in the pom. >> >> /B >> Den 2 jul 2015 19:01 skrev "Mark Waite" <[email protected]>: >> >>> That sounds great. Thanks. >>> >>> As one of the maintainers of the git plugin and the git client plugin, >>> I'd like findbugs reporting enabled on both jobs. The job is already >>> configured to run findbugs as a standard part of the build process. I do >>> not want the job to be marked unstable for findbugs warnings. In the >>> future, that may change, but for now, it is enough to report the findbugs >>> resuls without changing the status of the job. >>> >>> I do not want checksyle run on either of those projects at this time. >>> >>> If Nicolas De Loof feels differently, I defer to his preference. >>> >>> Thanks, >>> Mark Waite >>> >>> On Thu, Jul 2, 2015 at 9:18 AM Robert Sandell <[email protected]> >>> wrote: >>> >>>> By default nothing should happen. >>>> >>>> If you as a maintainer would want to have findbugs run and/or mark the >>>> build as unstable you can ask someone with configure job permissions on >>>> jenkins.ci.cloudbees.com to tick one or both of the new checkboxes on >>>> the config page of your plugin job. And update your pom to produce >>>> xmlOutput for findbugs: >>>> >>>> Example: >>>> <build> >>>> <plugins> >>>> <plugin> >>>> <groupId>org.codehaus.mojo</groupId> >>>> <artifactId>findbugs-maven-plugin</artifactId> >>>> <version>3.0.1</version> >>>> <configuration> >>>> <xmlOutput>true</xmlOutput> >>>> >>>> <findbugsXmlWithMessages>true</findbugsXmlWithMessages> >>>> <failOnError>false</failOnError> >>>> </configuration> >>>> </plugin> >>>> </plugins> >>>> </build> >>>> >>>> >>>> If you configure your pom to automatically run findbugs or checkstyle >>>> during for example the verify phase the Jenkins job should automatically >>>> pick that up. >>>> >>>> /B >>>> >>>> On Thu, Jul 2, 2015 at 5:03 PM, Mark Waite <[email protected]> >>>> wrote: >>>> >>>>> Can you explain a little further what that will mean? >>>>> >>>>> When I merge a change to the git-plugin, will the >>>>> https://jenkins.ci.cloudbees.com/job/plugins/job/git-plugin/ job now >>>>> fail because findbugs reports are being retrieved? >>>>> >>>>> Will there be another graph on the page which shows the findbugs >>>>> output for that job? >>>>> >>>>> Likewise for checkstyle. >>>>> >>>>> Thanks, >>>>> Mark Waite >>>>> >>>>> On Thu, Jul 2, 2015 at 8:45 AM Robert Sandell <[email protected]> >>>>> wrote: >>>>> >>>>>> I've changed the plugin template for maven to pick up findbugs and >>>>>> checkstyle reports* (on ttps://jenkins.ci.cloudbees.com >>>>>> <http://jenkins.ci.cloudbees.com>)* if any is generated by the >>>>>> build. So if plugin builds starts to fail for that reason you know who to >>>>>> blame ;) But it shouldn't change anything for existing jobs unless you >>>>>> actively do something. >>>>>> >>>>>> I've also added config options to run findbugs and mark the build as >>>>>> unstable if any findbugs issues are found, so maintainers can opt in for >>>>>> that if they want to. >>>>>> >>>>>> For my own plugins I run checkstyle in the compile phase so I didn't >>>>>> bother adding that option there. >>>>>> >>>>>> -- >>>>>> Robert Sandell >>>>>> *Software Engineer* >>>>>> *CloudBees Inc.* >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Jenkins Developers" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0bvoSb0CDYCEhhKfiwUHwayZ-mRxaCUNPfZGSC9Gzp7Q%40mail.gmail.com >>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0bvoSb0CDYCEhhKfiwUHwayZ-mRxaCUNPfZGSC9Gzp7Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> >>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEYz1rDjaaJV4j9hSZ0cNVwmFNTxw2oRxOh%2BkOD5Dv3rA%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEYz1rDjaaJV4j9hSZ0cNVwmFNTxw2oRxOh%2BkOD5Dv3rA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>> >>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>>> Robert Sandell >>>> *Software Engineer* >>>> *CloudBees Inc.* >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0vwdeyt%2BaLqKSfMFicQCnbG2%3DGKHEmmCwyYL%2Bx50ztTA%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0vwdeyt%2BaLqKSfMFicQCnbG2%3DGKHEmmCwyYL%2Bx50ztTA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> >> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEk6aq-NLKe-L4C_E17A-btzb%2B0%3DKtae6Er2MNpQJ3i%3Dw%40mail.gmail.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEk6aq-NLKe-L4C_E17A-btzb%2B0%3DKtae6Er2MNpQJ3i%3Dw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS2aMPkNFnJKRbxQc96nzRYM%2BQBPNWLZd0hcjrwq%2BC99kw%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS2aMPkNFnJKRbxQc96nzRYM%2BQBPNWLZd0hcjrwq%2BC99kw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtGgrKPAb%2B6nUQrcE-R16-rSxpq4fem4-RHq8cOVygAJmg%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtGgrKPAb%2B6nUQrcE-R16-rSxpq4fem4-RHq8cOVygAJmg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- Robert Sandell *Software Engineer* *CloudBees Inc.* -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS24zR-MqLn%2Bm1nyUy6AnmM5hFrAMKLRE7_fk4uJNPNgUQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
