> > Seems CloudBees decided to do it mass wide without discussing with Jenkins > community. ... Also, why only FB? Why not enable PMD? Why not silently > enable all static analysing collectors for jobs? >
The changes are not "mass wide", but the improvement in pull request builders has been announced by Robert about two weeks ago. There are pretty much plugins being modified, but the most of them are being maintained by by Jenkins contributors currently working at CloudBees. We want to improve the code quality of the plugins and reduce maintenance efforts by enforcing FindBugs in pull requests. I suppose such activity does not need additional approvals, because there's no binary compatibility loss, Jenkins core dependency changes or any other breaking changes requiring the discussion. Regarding other plugins... As any other Jenkins contributor, I'm eligible to create a pull request and then to get a feedback from plugin owners and other Jenkins contributors. *Nobody* merges my PRs without approvals of plugin owners. Even if there are possible improvements in the approach selected by me, I don't think that my pull requests violate any formal or informal contribution rules. Usage of static analysis has been discussed many times on Jenkins Governance meetings. The summary of these discussions was to encourage static analysis in plugins, so l'm strongly sure these PRs address the general need in a better quality of Jenkins plugins. FindBugs is one of the most popular tools for Java, so IMO it should be considered as an improvement even if it is a first baby step. If you want to integrate other tools, feel free to go forward, any contributions will be appreciated. jenkinsci/pom defines findbugs version in property > https://github.com/jenkinsci/pom/blob/master/pom.xml#L623 , no need > create custom property > Yes, it would be correct to use this property. I was not aware about it, so I introduced my one. It is not very important, because in plugin POMs we will definitely override this property to get newer FindBugs versions on old Jenkins cores. BTW I'll try to adjust my pull requests. Naming of strict variable is inconsistent > No need to keep the naming consistent (it would be preferable BTW). The current plugin POM architecture is not designed for effectively sharing FindBugs configurations across plugins, because they depend on Jenkins cores. We need a huge rework oof parent POMs architecture to make shared configs usable. Currently plugins need to manage static analysis flows on their own. > ... and seems future parent pom changes wasn't discussed in dev list > https://github.com/jenkinsci/maven-plugin/pull/48/files#r34896275 > <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fjenkinsci%2Fmaven-plugin%2Fpull%2F48%2Ffiles%23r34896275&sa=D&sntz=1&usg=AFQjCNF0NbZaVCppjTk595ckEmorxSyqyQ> > Yes, this *proposal* has not been discussed yet. I'm planning to start the discussion only when I have some time to handle it's follow ups. воскресенье, 19 июля 2015 г., 17:07:44 UTC+3 пользователь Ullrich Hafner написал: > > This option does exist in older releases of findbugs (2.x.x). It has been > removed in 3.0.0 release. > > I think maven ignores configuration options that are unused, so it is ok > to let the value as it is... > > > Am 19.07.2015 um 11:25 schrieb evernat <[email protected] <javascript:>>: > > This option does not exist but is documented in the wiki page (and help > files): > > https://wiki.jenkins-ci.org/display/JENKINS/FindBugs+Plugin#FindBugsPlugin-HowToUse > > Issue created: > https://issues.jenkins-ci.org/browse/JENKINS-29489 > > Le samedi 18 juillet 2015 16:04:06 UTC+2, Kanstantsin Shautsou a écrit : >> >> >> Where did you get this option [findbugsXmlWithMessages] ? >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/bdc1168a-e2ac-494a-a26b-93c86ed94235%40googlegroups.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/bdc1168a-e2ac-494a-a26b-93c86ed94235%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ece73619-68d9-4595-8cd8-61b90a182dba%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
