Well, as a non js dev when I read the word "bundle" I associate it with "a packaged versioned unit that is easily distributed and deployed". I didn't get that it was the globally scoped libs you wanted to get rid of, I read it as the other way around :)
/B On Mon, Sep 7, 2015 at 10:17 AM, Tom Fennelly <[email protected]> wrote: > I'm not sure what the questions is, but, module bundles can be loaded as > adjuncts too. That's not a problem. > > The bootstrap and jquery stapler adjunct examples you gave there are > exactly the type of thing we should be trying to get away from i.e. > globally scoped framework libs. jenkinsci/js-libs > <https://github.com/jenkinsci/js-libs> has a number of these bundled in a > way that makes them non global (which means we can deprecate, update etc > these libs in a safer way that's not possible with the old globally scoped > adjuncts). As for using libs like underscore ... you can just use standard > node/NPM install and "require" them in your CommonJS modular code. > > On 7 September 2015 at 08:51, Robert Sandell <[email protected]> > wrote: > >> What about the existing adjunct support in stapler? >> That is meant to work as treating js, jelly et.al packages as maven >> modules. >> >> See for example https://github.com/stapler/stapler-adjunct-bootstrap, >> https://github.com/stapler/stapler-adjunct-jquery and >> https://github.com/stapler/stapler-adjunct-underscore >> >> /B >> >> On Sun, Sep 6, 2015 at 8:34 PM, Tom Fennelly <[email protected]> >> wrote: >> >>> Hi Surya. We're not inventing anything new for the bundling/packaging >>> part. It uses Browserify for that, which is similar to Webpack. >>> >>> So you are not against the idea of adding build steps to Jenkins core re >>> supporting modularised JavaScript? >>> >>> Sent from my iPhone >>> >>> On 6 Sep 2015, at 17:23, Surya Gaddipati <[email protected]> >>> wrote: >>> >>> Hi Tom, >>> >>> I've been packaging all kinds of js stuff with webpack. Avoids all kinds >>> of problems with globals ect that you described. >>> I am not quite sure if we need to invent a jenkins specific solution >>> here. >>> >>> Here is an example using elm >>> >>> https://github.com/DotCi/DotCiPipelineViewer >>> >>> example using react and co >>> >>> https://github.com/groupon/DotCi >>> >>> None of those leaks globals. >>> >>> Surya >>> >>> On Saturday, September 5, 2015 at 7:32:01 AM UTC-5, Tom Fennelly wrote: >>>> >>>> Something that might help ... a description of the state of JavaScript >>>> in Jenkins as we see it >>>> <https://github.com/tfennelly/jenkins-js-modules#problem--motivation>. >>>> >>> -- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "Jenkins Developers" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/jenkinsci-dev/0wu31f3az_w/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/6948e86e-7313-44f9-93cd-ea6b42158093%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/6948e86e-7313-44f9-93cd-ea6b42158093%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/0B84D67D-5876-4BFC-ACA7-DDEE85F817D2%40gmail.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/0B84D67D-5876-4BFC-ACA7-DDEE85F817D2%40gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Robert Sandell >> *Software Engineer* >> *CloudBees Inc.* >> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/0wu31f3az_w/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS2OYYm_1KFzpJgSLRc2TJcWqyQ9ULjAmmRzqMbwdpyuOw%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS2OYYm_1KFzpJgSLRc2TJcWqyQ9ULjAmmRzqMbwdpyuOw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BbPaoK3-dfdEwzKk%3D_nNfWpJepPpiWrpwLNykYDy4HuRwYY%2Bg%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BbPaoK3-dfdEwzKk%3D_nNfWpJepPpiWrpwLNykYDy4HuRwYY%2Bg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- Robert Sandell *Software Engineer* *CloudBees Inc.* -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS3%2BDU4x8aYGuG4FqXNoku7MJkdg5FY%3DBMHBR5vX%3DLpijQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
